CI: minimal bridge prerequisites for Tokio I/O - #7317
Merged
harrishancock merged 1 commit intoSep 11, 2026
Conversation
harrishancock
force-pushed
the
harris/2026-09-11-tokio-minimal-prerequisites
branch
from
September 11, 2026 11:17
b1e87ea to
e297aff
Compare
Contributor
|
@harrishancock Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
harrishancock
force-pushed
the
harris/2026-09-11-tokio-minimal-prerequisites
branch
from
September 11, 2026 11:58
e297aff to
06b8128
Compare
The promise/future bridge needs only KJ async-core. Depending on the narrower target lets later Tokio-backed layers choose their own concrete event loop. Co-authored-by: Harris Hancock <harris@cloudflare.com> Assisted-by: Codex:gpt-5.6-sol,gpt-6-astra (cherry picked from commit 2ee84234393ef3beca7c7d8ece9adce8edbde7e3)
harrishancock
force-pushed
the
harris/2026-09-11-tokio-minimal-prerequisites
branch
2 times, most recently
from
September 11, 2026 13:21
7622fe6 to
644fa66
Compare
danlapid
approved these changes
Sep 11, 2026
harrishancock
marked this pull request as ready for review
September 11, 2026 15:17
harrishancock
enabled auto-merge
September 11, 2026 15:18
harrishancock
deleted the
harris/2026-09-11-tokio-minimal-prerequisites
branch
September 11, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR limits kj-rs's dependency to KJ's abstract async core, allowing the Tokio-backed layers to choose their own concrete event loop. The single commit changes only the dependency and its explanatory comment in
BUILD.bazel.The existing ArcWaker implementation and cold-by-default RustFuture conversion remain unchanged. The Tokio/I/O implementation and its explicit-start adaptations are in the full-stack draft; eager-by-default conversion is not a prerequisite.
Linux validation: the full Rust suite passed all 43 executed test targets, with
tsan:raceskipped.Assisted-by: Codex:gpt-6-astra