Skip to content

SQC-813 support hyperdrive local dev sslmodes verify-ca / verify-full#13599

Merged
petebacondarwin merged 1 commit intocloudflare:mainfrom
Ltadrian:agracia/SQC-813-support-verify-full
Apr 27, 2026
Merged

SQC-813 support hyperdrive local dev sslmodes verify-ca / verify-full#13599
petebacondarwin merged 1 commit intocloudflare:mainfrom
Ltadrian:agracia/SQC-813-support-verify-full

Conversation

@Ltadrian
Copy link
Copy Markdown
Contributor

@Ltadrian Ltadrian commented Apr 19, 2026

  • now support hyperdrive local dev sslmodes verify-ca / verify-full for postgres
  • now supports VERIFY_IDENTITY / VERIFY_CA for mysql
  • adds extra integration tests that verify sslmodes work as expected

Fixes: #11556

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:

macOS - postgres

  1. Create planetscale postgres db
  2. Copy connection string with verify-full and sslrootcert flags and paste into localConnectionString
  3. build wrangler locally and run npx wrangler dev
  4. Successfully connects to planetscale mysql db

macOS - mysql

  1. Create planetscale postgres db
  2. Copy connection string with VERIFY_IDENTITY paste into localConnectionString
  3. build wrangler locally and run npx wrangler dev
  4. Successfully connects to planetscale mysql db

Also manually tested on following save steps above:
Windows - postgres / mysql

  • Additional testing not necessary because: We have miniflare integration test suite / manual testing
  • Public documentation
    • Cloudflare docs PR(s): TODO
    • Documentation not necessary because:

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 19, 2026

🦋 Changeset detected

Latest commit: 5f8a05d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 19, 2026
@Ltadrian Ltadrian force-pushed the agracia/SQC-813-support-verify-full branch 2 times, most recently from 4893346 to e58c6ab Compare April 19, 2026 20:47
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 19, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13599

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13599

miniflare

npm i https://pkg.pr.new/miniflare@13599

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13599

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13599

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13599

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13599

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13599

wrangler

npm i https://pkg.pr.new/wrangler@13599

commit: 5f8a05d

@Ltadrian Ltadrian force-pushed the agracia/SQC-813-support-verify-full branch 2 times, most recently from 7d39e30 to e15077b Compare April 22, 2026 15:44
@Ltadrian Ltadrian marked this pull request as ready for review April 22, 2026 16:05
@workers-devprod workers-devprod requested review from a team and emily-shen and removed request for a team April 22, 2026 16:06
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 22, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

@Ltadrian Ltadrian force-pushed the agracia/SQC-813-support-verify-full branch from e15077b to 68a3305 Compare April 22, 2026 16:18
devin-ai-integration[bot]

This comment was marked as resolved.

for postgres/mysql
- adds extra integration tests that verify sslmodes work as expected
@Ltadrian Ltadrian force-pushed the agracia/SQC-813-support-verify-full branch from 68a3305 to 5f8a05d Compare April 22, 2026 17:07
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - can i confirm you've manually tested this?
and could you get a member of your team to review as well, i don't think i could spot a mistake in the implementation here 😅

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 24, 2026
@Ltadrian
Copy link
Copy Markdown
Contributor Author

lgtm - can i confirm you've manually tested this? and could you get a member of your team to review as well, i don't think i could spot a mistake in the implementation here 😅

@emily-shen Thank you for the review! I have manually tested on macOS / Windows for postgres / mysql hyperdrives all connecting to planetscale and the results are working as expected.

@emily-shen emily-shen added the skip-pr-description-validation Skip validation of the required PR description format label Apr 27, 2026
@petebacondarwin petebacondarwin merged commit 21b87b2 into cloudflare:main Apr 27, 2026
73 of 77 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-pr-description-validation Skip validation of the required PR description format

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Issue with Windows Hyperdrive configs locally

5 participants