SQC-813 support hyperdrive local dev sslmodes verify-ca / verify-full#13599
Conversation
🦋 Changeset detectedLatest commit: 5f8a05d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4893346 to
e58c6ab
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
7d39e30 to
e15077b
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers |
e15077b to
68a3305
Compare
for postgres/mysql - adds extra integration tests that verify sslmodes work as expected
68a3305 to
5f8a05d
Compare
emily-shen
left a comment
There was a problem hiding this comment.
lgtm - can i confirm you've manually tested this?
and could you get a member of your team to review as well, i don't think i could spot a mistake in the implementation here 😅
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
@emily-shen Thank you for the review! I have manually tested on macOS / Windows for postgres / mysql hyperdrives all connecting to planetscale and the results are working as expected. |
Fixes: #11556
macOS - postgres
macOS - mysql
Also manually tested on following save steps above:
Windows - postgres / mysql
A picture of a cute animal (not mandatory, but encouraged)