fix(miniflare): skip SNI for Hyperdrive IP targets#13708
Conversation
|
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
UnknownError: ProviderInitError |
|
@edmundhung Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
The fix is correct. This aligns with the TLS/SNI specification (RFC 6066 section 3), which states that SNI The LGTM |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Fixes #13599 .
The hyperdrive test fails in Node 25 as it has a stricter validation on
servernameand fails if it is an IP address.No changeset as the corresponding change is not yet released.
A picture of a cute animal (not mandatory, but encouraged)