Skip to content

[vitest-pool-workers] Make workerd verbose logging configurable - #14879

Merged
NuroDev merged 1 commit into
cloudflare:mainfrom
dmmulroy:feat/vitest-pool-workers-configurable-verbose
Jul 27, 2026
Merged

[vitest-pool-workers] Make workerd verbose logging configurable#14879
NuroDev merged 1 commit into
cloudflare:mainfrom
dmmulroy:feat/vitest-pool-workers-configurable-verbose

Conversation

@dmmulroy

@dmmulroy dmmulroy commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Adds a narrow, typed verbose option to cloudflareTest() / cloudflarePool() configuration and forwards it to the shared Miniflare options. This allows users to set verbose: false when caught Durable Object RPC errors would otherwise produce workerd structured INFO logs on stdout.

The option defaults to true, preserving existing behavior. This intentionally does not expose handleStructuredLogs or other arbitrary shared Miniflare handlers.

Validation:

  • pnpm -w test:ci -F @cloudflare/vitest-pool-workers -- structured-logs.test.ts
  • pnpm check --filter @cloudflare/vitest-pool-workers
  • pnpm exec oxfmt --check packages/vitest-pool-workers/src/pool/config.ts packages/vitest-pool-workers/src/pool/index.ts packages/vitest-pool-workers/test/structured-logs.test.ts .changeset/quiet-taxis-listen.md

The full package suite was also run, but currently fails unchanged on main: the temporary test installation resolves Vitest 4.1.10, whose output format no longer matches existing assertions in console.test.ts, chunking.test.ts, and filtering.test.ts. Running console.test.ts against a stashed clean main reproduced the same three failures.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this repository's package README delegates the detailed configuration reference to cloudflare-docs; the public option includes inline typed documentation and a changeset.

A picture of a cute animal (not mandatory, but encouraged)

Cute animal (Bodhi)

0DEEFC05-C7B2-4D3B-9D44-5A9E0D770529_1_102_o

Note

This is a contribution from an AI agent: Pi, GPT-5.6.

@changeset-bot

changeset-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b639129

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jul 27, 2026
@dmmulroy
dmmulroy marked this pull request as ready for review July 27, 2026 17:47
@pkg-pr-new

pkg-pr-new Bot commented Jul 27, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14879

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@14879

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14879

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14879

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14879

miniflare

npm i https://pkg.pr.new/miniflare@14879

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14879

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14879

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14879

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14879

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14879

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14879

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14879

wrangler

npm i https://pkg.pr.new/wrangler@14879

commit: b639129

@workers-devprod
workers-devprod requested review from a team and dario-piotrowicz and removed request for a team July 27, 2026 17:47
@workers-devprod

workers-devprod commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jul 27, 2026
@NuroDev
NuroDev merged commit e6480e3 into cloudflare:main Jul 27, 2026
71 of 74 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants