Avoid custom domain prompt for same Worker - #15434
Conversation
🦋 Changeset detectedLatest commit: 88404bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
There was a problem hiding this comment.
Maybe add a test for Wrangler Environments too? I get a bit nervous seeing just a bare scriptName floating around. Would like to just make sure we're covering Wrangler Environments too (since their name is dynamic).
Does that work now? Did you need to rebase or something? |
ddfdc7a to
c10948e
Compare
|
Rebased onto latest The test file path is
It passes locally. I rebuilt |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
52bdcd8 to
e1bec65
Compare
e1bec65 to
92b5d90
Compare
Summary
Context
Repro: deploy a Worker with a custom domain, then add
routes[].previews_enabledand redeploy in an interactive terminal. Before this change, Wrangler prompts even though the existing custom domain is already used by the same Worker.Validation
pnpm exec oxfmt --check .changeset/fuzzy-dogs-prompt.md packages/deploy-helpers/src/triggers/deploy.ts packages/deploy-helpers/src/triggers/publish-routes.ts packages/deploy-helpers/tests/publish-custom-domains.test.ts packages/wrangler/src/__tests__/deploy/routes.test.tsgit diff --checkpnpm --filter @cloudflare/deploy-helpers test run tests/publish-custom-domains.test.tspnpm --filter wrangler test run src/__tests__/deploy/routes.test.ts -t "should not confirm override if custom domain already belongs to this Worker"Checklist