WC-5936 Honor Workers Builds worker name overrides in wrangler preview - #15499
Merged
WillTaylorDev merged 1 commit intoSep 4, 2026
Merged
Conversation
Workers Builds sets an override so a Worker keeps its dashboard name even when a project's Wrangler config uses a different one. wrangler deploy already honored that override, but wrangler preview and its secrets, settings, and delete subcommands read the configured name directly and failed with a name mismatch error. Preview commands now check the override first, matching how deploy resolves the worker name.
🦋 Changeset detectedLatest commit: cf3624e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
edmundhung
and removed request for
a team
September 3, 2026 18:07
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
LGTM |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
ericclemmons
approved these changes
Sep 3, 2026
emily-shen
approved these changes
Sep 4, 2026
workers-devprod
approved these changes
Sep 4, 2026
workers-devprod
left a comment
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
WillTaylorDev
deleted the
willtaylor/wc-5936-wrangler-preview-ci-override-name
branch
September 4, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WC-5936
Workers Builds sets an override so a Worker keeps its dashboard name even when a project's Wrangler config uses a different one.
wrangler deployalready honored that override, butwrangler previewand its secrets, settings, and delete subcommands read the configured name directly and failed with a name mismatch error.Preview commands now check the override first, matching how deploy resolves the worker name.
deploybehavior forpreviewand doesn't add anything new for users.A picture of a cute animal (not mandatory, but encouraged)
