Skip to content

Revert "fix: Pages asset-server duplicating the hash component (#2303)"#3038

Merged
WalshyDev merged 2 commits into
mainfrom
revert-2303-duplicate-hash-component
Apr 13, 2023
Merged

Revert "fix: Pages asset-server duplicating the hash component (#2303)"#3038
WalshyDev merged 2 commits into
mainfrom
revert-2303-duplicate-hash-component

Conversation

@GregBrimble

Copy link
Copy Markdown
Contributor

This reverts commit 1a1f1dc.

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@GregBrimble
GregBrimble requested a review from a team as a code owner April 13, 2023 20:46
@changeset-bot

changeset-bot Bot commented Apr 13, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 976cc1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/pages-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GregBrimble
GregBrimble requested a review from a team as a code owner April 13, 2023 20:47
@github-actions

github-actions Bot commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4693670667/npm-package-wrangler-3038

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3038/npm-package-wrangler-3038

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4693670667/npm-package-wrangler-3038 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4693670667/npm-package-cloudflare-pages-shared-3038

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov

codecov Bot commented Apr 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #3038 (976cc1a) into main (5b6a4f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3038   +/-   ##
=======================================
  Coverage   73.84%   73.84%           
=======================================
  Files         167      167           
  Lines       10504    10504           
  Branches     2807     2807           
=======================================
  Hits         7757     7757           
  Misses       2747     2747           

@WalshyDev
WalshyDev merged commit 978471a into main Apr 13, 2023
@WalshyDev
WalshyDev deleted the revert-2303-duplicate-hash-component branch April 13, 2023 21:22
@github-actions github-actions Bot mentioned this pull request Apr 13, 2023
WalshyDev pushed a commit that referenced this pull request Apr 17, 2023
@github-actions github-actions Bot mentioned this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants