Skip to content

leftovers some more automation - #690

Merged
beyhan merged 1 commit into
mainfrom
leftovers-func
Aug 6, 2026
Merged

leftovers some more automation#690
beyhan merged 1 commit into
mainfrom
leftovers-func

Conversation

@ramonskie

@ramonskie ramonskie commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

addition to #684

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The pipeline adds reusable templates for relint environment updates, infrastructure destruction, and GCP DNS management. It replaces repeated inline task definitions across GCP deployment, failure, and smoke-test paths. Destruction tasks support ensure and on_failure hooks. DNS tasks support optional failure steps. The GCP acceptance test job now cleans up leftover environments on failure.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title indicates automation work but does not identify the specific reusable templates or pipeline changes. Use a specific title, such as "Extract reusable Concourse automation tasks for GCP deployments".
Description check ❓ Inconclusive The description only states that this change adds to issue #684 and does not explain the pipeline automation changes. Add a brief summary of the reusable templates and the pipeline configurations they replace.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch leftovers-func

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@beyhan
beyhan merged commit e144af4 into main Aug 6, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Aug 6, 2026
@beyhan
beyhan deleted the leftovers-func branch August 6, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants