Skip to content

Autocompletion uses the wrong function map for several commands #695

@maxim-hansen

Description

@maxim-hansen

The shell autocomplete feature merged in #629 is great, but has an annoying bug when working as a release developer.

Because several of the commands used during release authoring do not autocomplete as expected, like:

bosh add-blob

Which one would definitely expect would do file/path autocompletion to find the file you want to add as a blob to your release.

However, this command currently has the noFile complete function mapped, which I assume is the reason it's not allowing autocomplete to look up things on the filesystem:

reflect.TypeOf(opts.AddBlobArgs{}).Name(): c.noFile,

Same issue with the bosh vendor-package, which also requires us to browse on the filesystem to specify the source package directory:

reflect.TypeOf(opts.VendorPackageArgs{}).Name(): c.noFile,

I would suggest that both of these maps are changed to listFiles instead, so that we can actually autocomplete the required parameters for these commands.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions