fix: enable file autocompletion for add-blob and vendor-package commands#697
Merged
aramprice merged 1 commit intocloudfoundry:mainfrom Oct 2, 2025
Merged
Conversation
- Change AddBlobArgs from noFile to listFiles completion - Change VendorPackageArgs from noFile to listFiles completion - Allows filesystem autocomplete when specifying file paths Fixes cloudfoundry#695
The committers listed above are authorized under a signed CLA. |
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
aramprice
approved these changes
Sep 26, 2025
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bosh add-blobcommand to enable file path completionbosh vendor-packagecommand to enable directory path completionProblem
The shell autocompletion feature for the BOSH CLI has a bug affecting release developers. Several commands used during release authoring do not autocomplete as expected:
bosh add-blob- should allow file/path autocompletion to find files to add as blobsbosh vendor-package- should allow directory autocompletion to specify source package directoriesCurrently, these commands use the
noFilecomplete function which prevents filesystem autocompletion.Solution
Changed the completion function mapping for both commands from
c.noFiletoc.listFiles:File:
cmd/completion/complete_functions.goAddBlobArgsmapping changed fromc.noFiletoc.listFilesVendorPackageArgsmapping changed fromc.noFiletoc.listFilesThis allows users to:
bosh add-blob <tab>for filesystem autocompletion when selecting filesbosh vendor-package <tab>for filesystem autocompletion when selecting package directoriesTesting
The fix enables standard shell autocompletion for file/directory paths when using these commands.
Fixes #695