address flakes in ci

[mkocher]

• network tests go back to before each as they're modifying state
• remove event length assertion so we get a better failure message if the extra events show up again
• clean up mysql cmd to not emit a table header

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8603d61f-85b8-4531-8a12-e236cad1cbae

📥 Commits

Reviewing files that changed from the base of the PR and between 7458775 and 70bffb7.

📒 Files selected for processing (1)

• src/spec/shared/shared_support/mysql.rb

---

Walkthrough

The changes update test behavior in three areas. The orphaned VM cleanup test no longer requires exactly twice as many scheduler events as deployment instances. The network resolution spec resets its sandbox before each example. The MySQL helper suppresses column headers and returns all query result lines.

Suggested reviewers: aramprice

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description summarizes the changes but omits most required template sections, including tests, release notes, breaking changes, context, and reviewers.	Complete the required sections and include test results, release-note wording, breaking-change impact, contextual links, reviewer tags, and AI feedback status.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change as addressing CI test flakes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch address-test-flakes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/spec/shared/shared_support/mysql.rb`:
- Line 64: Remove the unreachable `|| []` fallback from the command output
expression in the shared MySQL support code, leaving `.lines.to_a` as the
explicit array-returning result.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fe892063-7b44-49e1-ac2b-21e84596e6d3

📥 Commits

Reviewing files that changed from the base of the PR and between 66de92e and 7458775.

📒 Files selected for processing (3)

• src/spec/integration/director_scheduler_spec.rb
• src/spec/integration/links/network_resolution_spec.rb
• src/spec/shared/shared_support/mysql.rb

💤 Files with no reviewable changes (1)

• src/spec/integration/director_scheduler_spec.rb