Skip to content

Add acceptance test for Cloud Controller API log emission#1920

Merged
jochenehret merged 1 commit intocloudfoundry:developfrom
sap-contributions:feature/test-for-ccng-app-logs
Apr 23, 2026
Merged

Add acceptance test for Cloud Controller API log emission#1920
jochenehret merged 1 commit intocloudfoundry:developfrom
sap-contributions:feature/test-for-ccng-app-logs

Conversation

@serdarozerr
Copy link
Copy Markdown
Contributor

Are you submitting this PR against the develop branch?

yes

What is this change about?

Adds an acceptance test to verify that Cloud Controller emits [API/*] lifecycle log messages (e.g. "Created app with guid ...") via loggregator when processing an app push. The test checks that these messages appear in the app's recent log stream end-to-end.

Please provide contextual information.

cloudfoundry/cloud_controller_ng#5043
cloudfoundry/capi-release#644
cloudfoundry/cf-deployment#1327

What version of cf-deployment have you run this cf-acceptance-test change against?

there will be new version since it includes changes also in cf-deployment

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

The [API/*] logs are part of the core CF app lifecycle and are relied upon by operators. This test validates that Cloud Controller correctly emits these logs end-to-end through the loggregator pipeline.

How many more (or fewer) seconds of runtime will this change introduce to CATs?

1-2 sec.

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

Cloud Controller emits lifecycle log messages (e.g. "Created app with guid ...")
via loggregator under the [API/*] source tag when processing an app push.

This test verifies those logs appear in the app's recent log stream, providing
an end-to-end check that the loggregator emitter in CCNG correctly forwards
messages through the loggregator v2 gRPC client introduced in
cloudfoundry/cloud_controller_ng#5043.
Copy link
Copy Markdown
Contributor

@johha johha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jochenehret jochenehret merged commit 1a3e5b4 into cloudfoundry:develop Apr 23, 2026
3 checks passed
@johha johha deleted the feature/test-for-ccng-app-logs branch April 23, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants