Skip to content

Various improvements #2 - #1025

Merged
FloThinksPi merged 10 commits into
mainfrom
explicit_linkss
Aug 15, 2025
Merged

Various improvements #2#1025
FloThinksPi merged 10 commits into
mainfrom
explicit_linkss

Conversation

@Samze

@Samze Samze commented Aug 13, 2025

Copy link
Copy Markdown
Contributor
  • Remove "Links" and replace with explicit links. This way the links for a resource are discoverable.
  • Add missing 401 error to all but /,/v3,/v3/info endpoints
  • Add missing location headers for 202 operations
  • 201 is only for User provided service creation
  • Update jobs to have specific links]
  • Add missing request bodies for services
  • Add support for https://swagger.io/docs/specification/v3_0/links/ for referencing relationships
  • Add missing endpoints for revisions

Samze added 2 commits August 13, 2025 14:12
* Fix get space parameters
* Fix erronous space request body to isolation seg
@Samze Samze changed the title Add explicit link references per resource Various improvements #2 Aug 14, 2025
@Samze
Samze requested review from FloThinksPi and Copilot August 14, 2025 02:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements comprehensive API improvements including standardizing error responses, adding location headers for asynchronous operations, and removing the generic "Links" schema in favor of explicit link definitions.

  • Remove generic "Links" schema and replace with explicit link properties for better discoverability
  • Add missing 401 (Unauthorized) error responses to all endpoints except root, /v3, and /v3/info
  • Add Location headers to 202 (Accepted) responses for asynchronous job operations
  • Update service creation to return 201 only for user-provided services, 202 for managed services
  • Add missing request body schemas for service operations

Reviewed Changes

Copilot reviewed 69 out of 69 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Multiple path files Add 401 error responses and Location headers for async operations
Schema files Replace generic Links with explicit link properties
Request body files Add new service instance and credential binding request body schemas
Info.yaml Remove 401 error from info endpoint (correctly excluded)
openapi.yaml Remove Links schema reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@FloThinksPi
FloThinksPi merged commit 828a24e into main Aug 15, 2025
2 checks passed
@Samze
Samze deleted the explicit_linkss branch August 15, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants