Skip to content

remove questionable words#217

Merged
crhino merged 1 commit intocloudfoundry:masterfrom
duglin:badWords
Jul 23, 2014
Merged

remove questionable words#217
crhino merged 1 commit intocloudfoundry:masterfrom
duglin:badWords

Conversation

@duglin
Copy link
Copy Markdown

@duglin duglin commented Jul 22, 2014

No description provided.

@cf-gitbot
Copy link
Copy Markdown

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/75469600.

@krishicks
Copy link
Copy Markdown
Contributor

@lcddave Any objection to this? This appears to only affect what words are used when the 'random-route' flag is passed when pushing an app.

Cheers,
@krishicks
CF Community Soloist

Comment thread words/dict/adjectives.txt Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added back in

@MarkKropf
Copy link
Copy Markdown
Contributor

It may actually be easier to find a published clean list of words instead of trying to fix this one. It'd be great if there were a clean list that was available in multiple languages. I wouldn't want anyone to attempt to translate any of this.

@duglin
Copy link
Copy Markdown
Author

duglin commented Jul 23, 2014

If a list exists sure - but until then I think we should play it safe and remove the ones we can identify now.

@MarkKropf
Copy link
Copy Markdown
Contributor

Makes sense, I wouldn't want someone to be surprised with a << horrible expletive >>.mybluemix.net

@lcddave
Copy link
Copy Markdown
Contributor

lcddave commented Jul 23, 2014

@duglin Is there a specific goal you're trying to accomplish with these edits? I'm okay with taking them, but as @MarkKropf mentioned the list may still not be quite clean for some definition of "questionable."

(I wasn't taking any action here because I was leaning toward retiring this implementation of random word anyway.)

@duglin
Copy link
Copy Markdown
Author

duglin commented Jul 23, 2014

I guess my goal was to try to avoid someone getting upset at our choice of words. If that's achieved by the edits I've proposed or by removal of this particular random word algorithm then either is fine with me. But I do think that while the longer-term decision is made I think taking the easy steps of removing the ones I've proposed would be a good thing - some of those words could get us into quite a bit of trouble.

@Amit-PivotalLabs
Copy link
Copy Markdown

This has piqued my curiosity. What kind of trouble can we get into with
these words?

On Wednesday, July 23, 2014, Doug Davis notifications@github.com wrote:

I guess my goal was to try to avoid someone getting upset at our choice of
words. If that's achieved by the edits I've proposed or by removal of this
particular random work algorithm then either is fine with me. But I do
think that while the longer-term decision is made I think taking the easy
steps of removing the ones I've proposed would be a good thing - some of
those words could get us into quite a bit of trouble.


Reply to this email directly or view it on GitHub
#217 (comment).

@duglin
Copy link
Copy Markdown
Author

duglin commented Jul 23, 2014

Would you want to be the person to explain to your customer why CF is generating names that have, say, the N-word in it?

@Amit-PivotalLabs
Copy link
Copy Markdown

Ah, didn't see the random-route part of the thread.

On Wed, Jul 23, 2014 at 2:47 PM, Doug Davis notifications@github.com
wrote:

Would you want to be the person to explain to your customer why CF is
generating names that have, say, the N-word in it?


Reply to this email directly or view it on GitHub
#217 (comment).

@MarkKropf
Copy link
Copy Markdown
Contributor

Yes, this is not censoring route words, it just adds assurance that we will not create a random route with words you can't say on TV. I think that's reasonable and something we should bring in. We've been lucky thus far, let's not wait for the first incident to make this more important.

@Amit-PivotalLabs
Copy link
Copy Markdown

Just found this:

https://github.com/shutterstock/List-of-Dirty-Naughty-Obscene-and-Otherwise-Bad-Words/

It has a plaintext file for bad words in English (en) as well as 20
additional languages. Filtering against the pull-requested nouns.txt finds
an additional 156 "bad words". Half of them aren't really bad (like
"style") but lots of them are definite no-nos.

Still, a whitelist would be ideal.

On Wed, Jul 23, 2014 at 3:34 PM, Mark Kropf notifications@github.com
wrote:

Yes, this is not censoring route words, it just adds assurance that we
will not create a random route with words you can't say on TV. I think
that's reasonable and something we should bring in. We've been lucky thus
far, let's not wait for the first incident to make this more important.


Reply to this email directly or view it on GitHub
#217 (comment).

@squeedee
Copy link
Copy Markdown
Contributor

It's still possible to cause offense. I started a project once that I felt
was doomed for failure because github offered something like
"wobbly-death-tantrums" or something to that effect.

On Wed, Jul 23, 2014 at 3:34 PM, Mark Kropf notifications@github.com
wrote:

Yes, this is not censoring route words, it just adds assurance that we
will not create a random route with words you can't say on TV. I think
that's reasonable and something we should bring in. We've been lucky thus
far, let's not wait for the first incident to make this more important.


Reply to this email directly or view it on GitHub
#217 (comment).

Rasheed Abdul-Aziz
Software Engineer
Pivotal Labs New York.

Level 2
625 Avenue of the Americas, New York, NY 10011

Mobile: +1 (646) 462-5466

@scottruitt
Copy link
Copy Markdown
Contributor

@duglin I apologize for not vetting the library as thoroughly as you, I'm appalled at what you've found. Definitely not the impression I want to create. Thanks for doing this.

crhino added a commit that referenced this pull request Jul 23, 2014
Merging this in, but it seems like a second pass might not be a terrible idea.
@crhino crhino merged commit 256152b into cloudfoundry:master Jul 23, 2014
@lcddave
Copy link
Copy Markdown
Contributor

lcddave commented Jul 23, 2014

On a lighter note, while this isn't autocorrect, seems like the two areas share similar challenges:

http://www.wired.com/2014/07/history-of-autocorrect/

haydonryan pushed a commit to haydonryan/cli that referenced this pull request Nov 7, 2014
Merging this in, but it seems like a second pass might not be a terrible idea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants