Skip to content

Conversation

@moleske
Copy link
Member

@moleske moleske commented Oct 18, 2023

  • This line was added for v8 and not v7 and main
  • It is not needed cause we test at the unit level and the assertion was incorrect anyway

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Where this PR should be backported?

  • main - all changes should by default start here
  • v8
  • v7

Description of the Change

fix broken tests
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

cause we can't release with broken tests
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

very cause we can't release with broken tests
Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

- This line was added for v8 and not v7 and main
- It is not needed cause we test at the unit level and the assertion was incorrect anyway
@ccjaimes ccjaimes merged commit 2ab9978 into v8 Oct 18, 2023
@ccjaimes ccjaimes deleted the fix-ssh-enabled-tip-integration-test branch October 18, 2023 22:33
@a-b a-b mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants