Fix unclear test descriptions#1023
Merged
elenasharma merged 9 commits intoDec 15, 2017
Merged
Conversation
|
Hey ablease! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/153402639 The labels on this github issue will be updated when the story is started. |
5 tasks
Gerg
approved these changes
Dec 13, 2017
[#152922808] Signed-off-by: Jen Spinney <jennifer.spinney@suse.com>
[#152922808] Signed-off-by: Sam Gunaratne <sgunaratne@pivotal.io>
[#152922808] Signed-off-by: Denise Yu <dyu@pivotal.io>
[#152922808] Signed-off-by: Denise Yu <dyu@pivotal.io>
* Add additional tests for user provided services and service instance sharing Signed-off-by: Sam Gunaratne <sgunaratne@pivotal.io>
422 Unprocessable is a more appropriate error message as the syntax of the request is correct, however the semantics of the request are wrong. [#153176525] Signed-off-by: Jen Spinney <jennifer.spinney@suse.com>
* This allows developers who does not have cross space access to discover the space_guid when using service instance sharing. [#153244755] Signed-off-by: Sam Gunaratne <sgunaratne@pivotal.io>
* This could introduce a name clash in spaces receiving a shared instance [#152109574]
deniseyu
force-pushed
the
pr-service-instance-sharing-fix-test-descriptions
branch
from
f2b6730 to
3d447ba
Compare
deniseyu
deleted the
pr-service-instance-sharing-fix-test-descriptions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR builds on top of #1020, which should be merged first. The actual changes on top of #1020 can be viewed in this diff.
In a previous PR (#980), it was suggested that we clear up some of the confusing names and descriptions in tests related to service instance sharing. Those comments can be found here.
This commit attempts to address that PR feedback.
There are no functional code changes in either the tests or the product.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
masterbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests
Thanks,
Sapiteam(Alex + @jenspinney)