Fix schema section in audit.service_plan.create event docs#1042
Merged
anniesing merged 1 commit intoDec 21, 2017
Merged
Conversation
* Old documentation for the returned event was incorrect in how the schemas are represented in the event. Fixed and included some simple example schemas. [#153557902]
|
Hey jenspinney! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/153748886 The labels on this github issue will be updated when the story is started. |
Contributor
Author
|
Travis CI test failure must either be a flake or a test broken on master. This is a small docs-only change. |
|
This PR looks good. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the documentation page for "List Service Plan Create Events", the schemas section of the example response is incorrect. This PR fixes it to match what the CC would actually respond with, including some sample simple schemas.
Story link: #153557902
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
masterbranch[n/a] I have run all the unit tests using
bundle exec rake[n/a] I have run CF Acceptance Tests