Cosmetic clean up in test file#1048
Merged
lisamburns merged 7 commits intoJan 17, 2018
Merged
Conversation
* If a user tries to share a service instance to multiple spaces at the same time and there are different problems with different potential target spaces, we now return a more detailed error message explainig which target spaces failed for which reason. * If a user tries to share a service instance into a target space for which they have write access, we now return a 422 instaed of a 403 for simplicity and API consistency. [#153629300] Signed-off-by: Alex Blease <ablease@pivotal.io>
[#153629300] Signed-off-by: Jen Spinney <jennifer.spinney@suse.com>
[#153629300] Signed-off-by: Alex Blease <ablease@pivotal.io>
[#152552023] Signed-off-by: Alex Blease <ablease@pivotal.io>
[#152552021] Signed-off-by: Denise Yu <dyu@pivotal.io>
[#153739127] Signed-off-by: Alex Blease <ablease@pivotal.io>
|
Hey jenspinney! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/153926165 The labels on this github issue will be updated when the story is started. |
This was referenced Jan 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback received during the review of PR #1024, specifically the comments here and here.
NOTE: This PR builds on top of #1041, which should be merged first. The actual changes on top of #1041 can be viewed in this diff.
What
This change renames some test variables and removes an extra response body from showing up during a test failure. The changes here are cosmetic and only in test code.
PR
masterbranchbundle exec rakeThanks,
Your friendly neighborhood SAPI team