Remove unused RingBuffer class

[Gerg]

Call was removed in 25efe93 as part of removing varz

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/174478509

The labels on this github issue will be updated when the story is started.

[tcdowney]

this was my go to ring buffer implementation 😞

looks alright to me

[tcdowney]

What's this for?

[Gerg]

Previously, RingBuffer was the first file loaded with the VCAP module defined:

• cloud_controller_ng/lib/cloud_controller.rb

  Line 11 in df570cb

  require 'sinatra/vcap'

• cloud_controller_ng/lib/sinatra/vcap.rb

  Line 1 in df570cb

  require 'vcap/ring_buffer'

  
  Removing RingBuffer has the side effect of causing http_constants.rb to fail loading because VCAP is undefined.

• cloud_controller_ng/lib/sinatra/vcap.rb

  Line 2 in df570cb

  require 'vcap/rest_api'

• cloud_controller_ng/lib/vcap/rest_api.rb

  Line 1 in df570cb

  require 'vcap/rest_api/http_constants'

• cloud_controller_ng/lib/vcap/rest_api/http_constants.rb

  Line 1 in df570cb

  module VCAP::RestAPI

[Gerg]

So, rather than shifting module definitions around for what random file gets to be the first one to define VCAP, I pulled it up to the top level.