Skip to content

Remove unused RingBuffer class #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gerg merged 1 commit into from
Aug 24, 2020
Merged

Remove unused RingBuffer class #1803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/cloud_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

require 'uaa/token_coder'

module VCAP; end
Copy link
Copy Markdown
Member

@tcdowney tcdowney Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

Copy link
Copy Markdown
Member Author

@Gerg Gerg Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, RingBuffer was the first file loaded with the VCAP module defined:

Copy link
Copy Markdown
Member Author

@Gerg Gerg Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, rather than shifting module definitions around for what random file gets to be the first one to define VCAP, I pulled it up to the top level.


require 'sinatra/vcap'
require File.expand_path('../config/environment', __dir__)

Expand Down
1 change: 0 additions & 1 deletion lib/sinatra/vcap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require 'vcap/ring_buffer'
require 'vcap/rest_api'
require 'vcap/request'
require 'presenters/error_presenter'
Expand Down
16 changes: 0 additions & 16 deletions lib/vcap/ring_buffer.rb
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions spec/unit/lib/vcap/ring_buffer_spec.rb
View file
Open in desktop

This file was deleted.