Validate JobPollableModel is updated before DelayedJob#2053
Merged
JenGoldstrich merged 1 commit intocloudfoundry:mainfrom Mar 4, 2021
Merged
Validate JobPollableModel is updated before DelayedJob#2053JenGoldstrich merged 1 commit intocloudfoundry:mainfrom
JenGoldstrich merged 1 commit intocloudfoundry:mainfrom
Conversation
Adding test to validate that the JobPollableModel insert happens before the DelayedJob insert when an asynchronous task is enqueued. This is done by adding callbacks that wrap the DelayedJob before Callback and also execute before the after Callback to extract the current state of each model as the callback lifecycle progresses. This test is designed to validate the elimination of the race condition identified in issue cloudfoundry#1973 and prevent reoccurrence.
|
|
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/176474130 The labels on this github issue will be updated when the story is started. |
Contributor
|
Hey @tpoland Thanks for this commit, and for linking the previous PR for historical context, this test seems super valuable to me. Merging this now, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a test to validate that the JobPollableModel insert happens
before the DelayedJob insert when an asynchronous task is enqueued.
This is done by adding callbacks that wrap the DelayedJob before
Callback and also execute before the after Callback to extract the
current state of each model as the callback lifecycle progresses.
This test is designed to validate the elimination of the race
condition identified in PR #1973 and prevent reoccurrence.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests