Change after_enqueue of enqueuer to before_enqueue and generate guid for delayed_job#1973
Merged
weymanf merged 2 commits intocloudfoundry:mainfrom Dec 9, 2020
Conversation
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/175876867 The labels on this github issue will be updated when the story is started. |
|
|
svkrieger
force-pushed
the
ISSUE-1950-fix-hanging-v3-delete-requests
branch
from
385ad5c to
8cdd06f
Compare
svkrieger
force-pushed
the
ISSUE-1950-fix-hanging-v3-delete-requests
branch
from
8cdd06f to
7ec5204
Compare
This comment has been minimized.
This comment has been minimized.
FelisiaM
referenced
this pull request
Dec 17, 2020
tpoland
pushed a commit
to tpoland/cloud_controller_ng
that referenced
this pull request
Jan 5, 2021
Adding test to validate that the JobPollableModel insert happens before the DelayedJob insert when an asynchronous task is enqueued. This is done by adding callbacks that wrap the DelayedJob before Callback and also execute before the after Callback to extract the current state of each model as the callback lifecycle progresses. This test is designed to validate the elimination of the race condition identified in issue cloudfoundry#1973 and prevent reoccurrence.
tpoland
pushed a commit
to tpoland/cloud_controller_ng
that referenced
this pull request
Jan 6, 2021
Adding test to validate that the JobPollableModel insert happens before the DelayedJob insert when an asynchronous task is enqueued. This is done by adding callbacks that wrap the DelayedJob before Callback and also execute before the after Callback to extract the current state of each model as the callback lifecycle progresses. This test is designed to validate the elimination of the race condition identified in issue cloudfoundry#1973 and prevent reoccurrence.
tpoland
pushed a commit
to tpoland/cloud_controller_ng
that referenced
this pull request
Jan 6, 2021
Adding test to validate that the JobPollableModel insert happens before the DelayedJob insert when an asynchronous task is enqueued. This is done by adding callbacks that wrap the DelayedJob before Callback and also execute before the after Callback to extract the current state of each model as the callback lifecycle progresses. This test is designed to validate the elimination of the race condition identified in issue cloudfoundry#1973 and prevent reoccurrence.
tpoland
pushed a commit
to tpoland/cloud_controller_ng
that referenced
this pull request
Jan 12, 2021
Adding test to validate that the JobPollableModel insert happens before the DelayedJob insert when an asynchronous task is enqueued. This is done by adding callbacks that wrap the DelayedJob before Callback and also execute before the after Callback to extract the current state of each model as the callback lifecycle progresses. This test is designed to validate the elimination of the race condition identified in issue cloudfoundry#1973 and prevent reoccurrence.
tpoland
pushed a commit
to tpoland/cloud_controller_ng
that referenced
this pull request
Jan 13, 2021
Adding test to validate that the JobPollableModel insert happens before the DelayedJob insert when an asynchronous task is enqueued. This is done by adding callbacks that wrap the DelayedJob before Callback and also execute before the after Callback to extract the current state of each model as the callback lifecycle progresses. This test is designed to validate the elimination of the race condition identified in issue cloudfoundry#1973 and prevent reoccurrence.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
The PR moves the logic for creating an entry in the ccdb's jobs table from the after_enqueue hook to the before_enqueue hook. With this it is guaranteed that the entry in the jobs table is already created before the job entry in the ccdb's delayed_jobs table is created and picked up by the worker.
An explanation of the use cases your change solves
The PR is an suggestion for solving the ISSUE: Hanging cf api v3 DELETE requests (cf7 delete, delete-route, delete-space, unset-space-role) #1950
It is not ready for production, as the unit tests in spec/unit/jobs/pollable_job_wrapper_spec.rb fail due to the changes.
It could have possible side-effects and require your review.
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
masterbranchI have run all the unit tests using
bundle exec rakeYes but the tests in spec/unit/jobs/pollable_job_wrapper_spec.rb failed due to the logic changes.
I have run CF Acceptance Tests