Fix state handling for GET /v3/service_instances/:guid/parameters#2750
Merged
philippthun merged 3 commits intocloudfoundry:mainfrom Jul 4, 2022
Conversation
svkrieger
force-pushed
the
fix-state-handling-for-get-service-instances-params
branch
from
bee3b23 to
b33b26d
Compare
svkrieger
force-pushed
the
fix-state-handling-for-get-service-instances-params
branch
2 times, most recently
from
fba612c to
e6373d9
Compare
- Return `ServiceInstanceNotFound` when state is `create failed` - Return more specific error when state is `delete in progress`
svkrieger
force-pushed
the
fix-state-handling-for-get-service-instances-params
branch
from
e6373d9 to
b2148e8
Compare
philippthun
reviewed
Jul 1, 2022
philippthun
approved these changes
Jul 1, 2022
Member
|
Will be merged together with the related PRs... |
will-gant
pushed a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 16, 2022
…oudfoundry#2750) Return `ServiceInstanceNotFound` when state is `create failed`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
ServiceInstanceNotFoundwhen service instance state iscreate failedAn explanation of the use cases your change solves
This PR solves the described issues according to State handling in v3 service instance endpoints #2713
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests