Skip to content

[ARI] Add svkrieger as capi approver#401

Merged
Gerg merged 1 commit intocloudfoundry:mainfrom
svkrieger:add-svkrieger-as-capi-approver
Sep 15, 2022
Merged

[ARI] Add svkrieger as capi approver#401
Gerg merged 1 commit intocloudfoundry:mainfrom
svkrieger:add-svkrieger-as-capi-approver

Conversation

@svkrieger
Copy link
Copy Markdown
Contributor

@svkrieger svkrieger commented Sep 6, 2022

About Me

I'm a developer at SAP working together with @philippthun, @FloThinksPi, @jochenehret, @stephanme and @johha on operating and improving Capi and related projects.

Contributions

In the past ~18 months I was involved in a number for contributions, discussions etc. which qualifies me to be an approver for Capi.

Issues (newest first)

Prevent service broker deadlock: cloudfoundry/cloud_controller_ng#2937
Service instance state handling in V3: cloudfoundry/cloud_controller_ng#2713
Outstanding requests metric bug: cloudfoundry/cloud_controller_ng#2393
Service binding parameters bug: cloudfoundry/cloud_controller_ng#2161
Hanging cf api v3 delete requests: cloudfoundry/cloud_controller_ng#1950

cloud_controller_ng PRs (newest first)

Prevent service broker deadlock: cloudfoundry/cloud_controller_ng#2939
[MINOR] Add missing parameter in docs: cloudfoundry/cloud_controller_ng#2922
Fix flakey tests:
cloudfoundry/cloud_controller_ng#2902
cloudfoundry/cloud_controller_ng#2747
V3 service instance state handling PRs:
cloudfoundry/cloud_controller_ng#2756
cloudfoundry/cloud_controller_ng#2750
cloudfoundry/cloud_controller_ng#2739
cloudfoundry/cloud_controller_ng#2737
cloudfoundry/cloud_controller_ng#2730
Implement exponential backoff for service fetch operations:
cloudfoundry/cloud_controller_ng#2680
cloudfoundry/cloud_controller_ng#2667
Fix outstanding metric bug: cloudfoundry/cloud_controller_ng#2394
Implement space application supporter: cloudfoundry/cloud_controller_ng#2349
Fix service binding parameters bug: cloudfoundry/cloud_controller_ng#2163
Favor 401 over 429 when token is expired: cloudfoundry/cloud_controller_ng#2079
Fix hanging cf api v3 delete requests: cloudfoundry/cloud_controller_ng#1973

slack conversations

https://cloudfoundry.slack.com/archives/C02FL4A2K/p1658391104997169
https://cloudfoundry.slack.com/archives/C07C04W4Q/p1616585842025800
https://cloudfoundry.slack.com/archives/C07C04W4Q/p1612430252045700

@emalm emalm added the wg label Sep 6, 2022
@emalm emalm requested a review from Gerg September 6, 2022 15:41
@Gerg Gerg changed the title Add svkrieger as capi approver [ARI] Add svkrieger as capi approver Sep 7, 2022
@Gerg
Copy link
Copy Markdown
Member

Gerg commented Sep 7, 2022

Per https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#promotion-and-revocation, you need 2 existing approvers to review your application and confirm that you meet the criteria for the role. I see @philippthun already approved the promotion, so you will need one more.

Once that criteria is met, I'll merge this PR.

@philippthun
Copy link
Copy Markdown
Member

I would find it valuable if a new committer would not only be approved/promoted by colleagues from the same company (in this case SAP), but also from someone else. So @sethboyles, @moleske, @MerricdeLauney, what do you think about Sven's contributions?

Copy link
Copy Markdown
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sven's contributions have been great, really glad you dealt with the service instance state issues. That helped a lot of users

@sethboyles
Copy link
Copy Markdown
Member

Agreed, Sven would be a welcome addition to CAPI approvers

@Gerg Gerg merged commit 59ff68e into cloudfoundry:main Sep 15, 2022
@Gerg
Copy link
Copy Markdown
Member

Gerg commented Sep 15, 2022

Welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants