Prevent binding creation when instance is in state 'create failed'#2808
Merged
philippthun merged 1 commit intocloudfoundry:mainfrom Jul 5, 2022
Conversation
philippthun
force-pushed
the
no-binding-creation-when-instance-in-failed-state
branch
from
330cc20 to
cff756a
Compare
- Apply changes done in ServiceCredentialBindingAppCreate also to ServiceCredentialBindingKeyCreate and ServiceRouteBindingCreate. - Move common code into ServiceBindingCreate.
philippthun
force-pushed
the
no-binding-creation-when-instance-in-failed-state
branch
from
cff756a to
90bb223
Compare
philippthun
changed the title
FloThinksPi
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceCredentialBindingAppCreate[1] also toServiceCredentialBindingKeyCreateandServiceRouteBindingCreate.ServiceBindingCreate.[1] #2756
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests