Skip to content

Fix state handling for POST /v3/spaces/:guid/actions/apply_manifest#2756

Merged
philippthun merged 5 commits intocloudfoundry:mainfrom
sap-contributions:fix-state-handling-for-post-apply-manifest
Jul 4, 2022
Merged

Fix state handling for POST /v3/spaces/:guid/actions/apply_manifest#2756
philippthun merged 5 commits intocloudfoundry:mainfrom
sap-contributions:fix-state-handling-for-post-apply-manifest

Conversation

@svkrieger
Copy link
Copy Markdown
Contributor

@svkrieger svkrieger commented Apr 7, 2022

A short explanation of the proposed change:

  • Return an error when service instance is in state create failed

An explanation of the use cases your change solves

- Return an error when service instance has state `create failed`
- Return an error when last operation is `delete in progress`
- Allow service binding creations for service instances with state `delete failed`
- Add more tests to cover all service instance states
@svkrieger svkrieger force-pushed the fix-state-handling-for-post-apply-manifest branch from 76b78f4 to 608af52 Compare June 24, 2022 07:56
Comment thread app/actions/app_apply_manifest.rb Outdated
Comment thread app/actions/app_apply_manifest.rb Outdated
Comment thread app/actions/app_apply_manifest.rb Outdated
Comment thread app/actions/app_apply_manifest.rb Outdated
Comment thread spec/unit/actions/app_apply_manifest_spec.rb
Comment thread spec/unit/actions/app_apply_manifest_spec.rb
Comment thread spec/unit/actions/app_apply_manifest_spec.rb
@svkrieger svkrieger requested a review from philippthun July 4, 2022 07:30
@philippthun
Copy link
Copy Markdown
Member

Will be merged together with the related PRs...

@philippthun philippthun merged commit e73a834 into cloudfoundry:main Jul 4, 2022
will-gant pushed a commit to sap-contributions/cloud_controller_ng that referenced this pull request Dec 16, 2022
…loudfoundry#2756)

Return an error when service instance has state `create failed`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants