Log async upload job details correlated with operation id - #1889
Merged
IvanBorislavovDimitrov merged 1 commit intoAug 11, 2026
Merged
Conversation
vkalapov
previously approved these changes
Aug 10, 2026
vkalapov
left a comment
Contributor
There was a problem hiding this comment.
Looks good but check the sonar scan warnings before merge.
Contributor
Author
|
Addressed the SonarCloud warnings in bdb2e34:
Both |
IvanBorislavovDimitrov
force-pushed
the
log-async-upload-job-for-operation-clean
branch
2 times, most recently
from
August 11, 2026 10:40
24adb5e to
1c4258a
Compare
When an operation starts, log the async upload job (deploy-from-URL scenario) associated with that operation, correlated by the operation id, in a single greppable INFO line. - StartProcessListener resolves the operation's file ids and queries AsyncUploadJobService for the associated jobs, logging one summary line per job; lookup failures log a WARN instead of failing the operation. - AsyncUploadJobEntry gains a credential-free buildLogSummary() plus queue-wait / upload-duration / total-time derivations computed over time-zone-aware Instants; timings render as N/A when timestamps are not set yet. The summary omits url, user and spaceGuid. - Tests cover the timing derivations, sensitive-data redaction, the logged-jobs path and the best-effort failure path.
IvanBorislavovDimitrov
force-pushed
the
log-async-upload-job-for-operation-clean
branch
from
August 11, 2026 11:09
1c4258a to
767fa30
Compare
|
vkalapov
approved these changes
Aug 11, 2026
IvanBorislavovDimitrov
deleted the
log-async-upload-job-for-operation-clean
branch
August 11, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
When an operation starts, log the async upload job (deploy-from-URL scenario) associated with that operation, correlated by the operation id — in a single, greppable line.
Previously there was no log line tying a deploy operation to its async upload job. The only shared key between the two is the uploaded file id (
appArchiveId), and it was never logged next to the operation id, so correlating an operation with its upload required manual cross-referencing.Changes
StartProcessListener— after files are stamped with the operation id, resolve the operation's file ids (appArchiveId+ ext-descriptor ids) viaOperationFileIdsUtiland queryAsyncUploadJobService.withFileIds(...). For each associated job, log one INFO line:Best-effort: operations without file ids (e.g. undeploy) short-circuit, and any lookup failure logs a WARN rather than failing the operation. Injects
AsyncUploadJobService(already available transitively, same asOrphanedFilesCleaner).AsyncUploadJobEntry— adds a credential-freebuildLogSummary()plus timing derivations:getQueueWaitTime()=addedAt → startedAt(time parked in the queue)getUploadDuration()=startedAt → finishedAt(actual upload time)getTotalTime()=addedAt → finishedAtnull(rendered asN/A) when the relevant timestamps are not set yet.Sensitive data — the summary intentionally omits
urlanduser(may carry basic-auth credentials / PII) andspaceGuid.Tests
AsyncUploadJobEntryTest— timing derivations for finished/running/initial jobs, sensitive-data redaction, andN/Arendering.StartProcessListenerTestfor the new constructor dependency.Both suites green;
multiapps-controller-persistenceand-processbuild clean.