feat: replace fork IT trigger comment with pull_request_target approval gate - #154
Conversation
…al gate Fork PRs now automatically trigger integration test workflows on each push. A lightweight gate job pauses execution pending approval by a committer via the fork-pr-integration-test GitHub environment. Same-repo PRs skip the gate and run tests immediately. Removes the fork-integration-trigger.yml workflow and report-fork-status action, both of which were only needed for the old dispatch-based approach.
|
Proposal by @FloThinksPi Makes things simpler using standard Github features (pull_request_target trigger + environment gate): no magic comment that you have to remember, no extra status reporting with duplicated checks (skipped and green ones). |
|
ITs don't run because there is a bootstrapping problem. Here's what happens with this PR open:
Neither trigger fires because this PR is changing the trigger itself. Once it merges to main, future PRs will work correctly. To run ITs for this PR's changes, use To handle this, a repo admin can temporarily allow admins to bypass the branch protection rules and then merge the PR. |
|
Ran manually the DAV Integration Tests. |
|
Merged bypassing the missing ITs (see comment above). |
Fork PRs now automatically trigger integration test workflows on each push. A lightweight gate job pauses execution pending approval by a committer via the fork-pr-integration-test GitHub environment. Same-repo PRs skip the gate and run tests immediately.
Removes the fork-integration-trigger.yml workflow and report-fork-status action, both of which were only needed for the old dispatch-based approach.