docs(build): require make from the repository root#5563
Merged
norman-abramovitz merged 1 commit intoJul 4, 2026
Conversation
nabramovitz
force-pushed
the
norm/docs/make-from-root
branch
from
857575e to
a223417
Compare
norman-abramovitz
approved these changes
Jul 4, 2026
norman-abramovitz
left a comment
norman-abramovitz
left a comment
Contributor
There was a problem hiding this comment.
LGTM testing doc gate
This was referenced Jul 4, 2026
norman-abramovitz
pushed a commit
that referenced
this pull request
Jul 4, 2026
The per-package 'Frontend Tests (x)' names are required status checks. A job-level skip collapses the matrix, so those contexts never report and stay 'expected', blocking the merge (seen on the docs-only #5563: '7 of 12 required status checks are expected'). Step-level gating lets each shard spin up, no-op, and report success. Single-job skips (Lint, Backend, Build Check, STB) report their one context fine and keep their job-level gates.
GNU make has no top-level-makefile search path and the root targets carry generated-file dependencies (extra_plugins.go et al) that ad-hoc subdirectory builds skip, yielding a backend that crashes at startup when CF-hosted.
nabramovitz
force-pushed
the
norm/docs/make-from-root
branch
from
a223417 to
45b01ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents that all make commands must run from the repository root: GNU make has no search path for its top-level makefile (
-Ionly affectsincludedirectives), and the root targets carry generated-file dependencies that ad-hoc subdirectory builds skip — e.g.go buildfromsrc/jetstreamomits the generatedextra_plugins.go, producing a backend without the Cloud Foundry plugin that crashes at startup when deployed as a CF app (the failure mode hit while measuring for #5550).Doc-only change to
docs/build-and-packaging.md.