Skip to content

Conversation

@strehle
Copy link
Member

@strehle strehle commented Nov 11, 2024

Needed for SLO

Be independent from browser session and present the IdP the session index.
If SOAP Binding , then this is a requirement

This enhancement ensures that there is element
<saml2p:SessionIndex>S-SP-04de8956-df80-46ef-886c-xxxxxxxx</saml2p:SessionIndex>
in the LogoutRequest from UAA towards SAML IdP.

This element was there with develop branch therefore it should be set in updated version.

<saml2p:LogoutRequest xmlns:saml2p="urn:oasis:names:tc:SAML:2.0:protocol"
                      Destination="https://idp/saml2/idp/slo/endpoint"
                      ID="LRb9d0b60e-a8d9-4b5c-924a-bbc864442b80"
                      IssueInstant="2024-11-12T11:26:10.070Z"
                      Version="2.0"
                      >
    <saml2:Issuer xmlns:saml2="urn:oasis:names:tc:SAML:2.0:assertion">cloudfoundry-saml-login</saml2:Issuer>
    <saml2:NameID xmlns:saml2="urn:oasis:names:tc:SAML:2.0:assertion">myname</saml2:NameID>
    <saml2p:SessionIndex>S-SP-04de8956-df80-46ef-886c-xxxxxxxx</saml2p:SessionIndex>
</saml2p:LogoutRequest>

dependabot bot and others added 2 commits November 11, 2024 14:20
…3120)

Bumps `versions.tomcatCargoVersion` from 9.0.96 to 9.0.97.

Updates `org.apache.tomcat.embed:tomcat-embed-el` from 9.0.96 to 9.0.97

Updates `org.apache.tomcat.embed:tomcat-embed-core` from 9.0.96 to 9.0.97

Updates `org.apache.tomcat.embed:tomcat-embed-jasper` from 9.0.96 to 9.0.97

Updates `org.apache.tomcat:tomcat-jdbc` from 9.0.96 to 9.0.97

---
updated-dependencies:
- dependency-name: org.apache.tomcat.embed:tomcat-embed-el
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.tomcat.embed:tomcat-embed-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.tomcat.embed:tomcat-embed-jasper
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.tomcat:tomcat-jdbc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@strehle strehle requested a review from duanemay November 11, 2024 16:41
@strehle
Copy link
Member Author

strehle commented Nov 12, 2024

Copy link
Member

@duanemay duanemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strehle strehle merged commit acf805d into new-saml-0530 Nov 12, 2024
@strehle strehle deleted the new-saml-0530-saml-session-index branch November 12, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants