Refactor time comparison test assertions#3725
Merged
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors time comparison test assertions to use more concise AssertJ assertion methods, following the pattern established in PR #3720. The changes simplify test assertions and remove unused imports.
Changes:
- Replace chained
isGreaterThanOrEqualTo().isLessThanOrEqualTo()assertions withisBetween()in LoginMockMvcTests - Simplify time boundary assertion in UaaTokenStoreTests and add a descriptive message
- Remove unused JUnit parameterized test imports and reorganize Jakarta servlet imports
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| LoginMockMvcTests.java | Refactors time comparison assertion to use isBetween() and reorganizes imports |
| UaaTokenStoreTests.java | Simplifies time boundary assertion and adds descriptive message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
server/src/test/java/org/cloudfoundry/identity/uaa/oauth/UaaTokenStoreTests.java
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
strehle
approved these changes
Jan 24, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve a couple more time comparison based on the pattern in #3720