feat(e2e): add optional ref input to e2e action#60
Merged
Conversation
Allows callers to pin the checkout to a specific commit SHA, branch, or tag. When omitted (empty string), actions/checkout falls back to the default branch — preserving existing nightly behaviour. Required for comment-driven e2e runs triggered via issue_comment, where the workflow runs from main but needs to test the PR's code. Signed-off-by: D072950 <abhijith.ravindra@sap.com>
There was a problem hiding this comment.
Pull request overview
Adds an optional ref input to the workflows/e2e composite action so callers can control which commit/branch/tag of cloudoperators/greenhouse is checked out before running E2E, while keeping the default behavior unchanged when ref is not provided.
Changes:
- Introduces a new optional
refinput (default"") for the E2E composite action. - Passes
inputs.refinto theactions/checkoutstep when checking outcloudoperators/greenhouse.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IvoGoman
approved these changes
May 26, 2026
abhijith-darshan
added a commit
to cloudoperators/greenhouse
that referenced
this pull request
May 26, 2026
The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
abhijith-darshan
added a commit
to cloudoperators/greenhouse
that referenced
this pull request
May 26, 2026
…#2027) The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
k-fabryczny
pushed a commit
to cloudoperators/greenhouse
that referenced
this pull request
May 29, 2026
…#2027) The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
k-fabryczny
pushed a commit
to cloudoperators/greenhouse
that referenced
this pull request
May 29, 2026
…#2027) The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> Signed-off-by: Klaudiusz Fabryczny <klaudiusz.fabryczny@sap.com>
k-fabryczny
pushed a commit
to cloudoperators/greenhouse
that referenced
this pull request
May 29, 2026
…#2027) The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
k-fabryczny
pushed a commit
to cloudoperators/greenhouse
that referenced
this pull request
May 29, 2026
…#2027) The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> Signed-off-by: Klaudiusz Fabryczny <klaudiusz.fabryczny@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refinput to theworkflows/e2ecomposite action""),actions/checkoutfalls back to the default branch — preserving existing nightly behaviourWhy
The
ci-e2e-run.yamlworkflow incloudoperators/greenhouseis triggered viaissue_comment, which always runs from the default branch. Without arefinput, the e2e action always checks out main instead of the PR's code.Test plan
refpassed) still checks out mainref) checks out the PR's commit