fix(ci): pass PR SHA as ref to e2e action and drop redundant checkout#2027
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ad-hoc PR-triggered E2E runner workflow to ensure the E2E composite action checks out and runs against the PR head SHA (rather than defaulting to the repository default branch), and removes redundant checkout/token configuration that interfered with the action’s internal checkout.
Changes:
- Pass
ref: ${{ needs.parse.outputs.sha }}intocloudoperators/common/workflows/e2eso E2E runs against the PR head SHA. - Remove the explicit “Checkout PR head” step from the
e2ejob (checkout handled inside the common E2E action). - Remove job-level
GITHUB_TOKENenv from thee2ejob to avoid duplicateAuthorizationheaders during internal checkout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IvoGoman
previously approved these changes
May 26, 2026
The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
abhijith-darshan
force-pushed
the
fix/e2e-run-ref
branch
from
afb1e72 to
27730d3
Compare
IvoGoman
approved these changes
May 26, 2026
k-fabryczny
pushed a commit
that referenced
this pull request
May 29, 2026
…#2027) The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
k-fabryczny
pushed a commit
that referenced
this pull request
May 29, 2026
…#2027) The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> Signed-off-by: Klaudiusz Fabryczny <klaudiusz.fabryczny@sap.com>
k-fabryczny
pushed a commit
that referenced
this pull request
May 29, 2026
…#2027) The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com>
k-fabryczny
pushed a commit
that referenced
this pull request
May 29, 2026
…#2027) The e2e action now accepts a ref input (cloudoperators/common#60). Passing the PR head SHA ensures the correct code is tested rather than the default branch. Also removes the now-redundant Checkout PR head step and the job-level GITHUB_TOKEN env that caused duplicate Authorization headers. Depends on: cloudoperators/common#60 Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> Signed-off-by: Klaudiusz Fabryczny <klaudiusz.fabryczny@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Passes
ref: <PR head SHA>to thecloudoperators/common/workflows/e2ecomposite action so e2e tests run against the PR's code rather than main. Drops the now-redundantCheckout PR headstep (the common action handles checkout internally) and removes the job-levelGITHUB_TOKENenv that caused duplicateAuthorizationheaders on the internal git fetch.Depends on cloudoperators/common#60.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist