chore(docs): create ADR for client-side routing#1033
Merged
Conversation
|
hodanoori
previously approved these changes
Jun 26, 2025
Contributor
hodanoori
left a comment
There was a problem hiding this comment.
Thanks for preparing this ADR
TilmanHaupt
previously approved these changes
Jun 26, 2025
ArtieReus
reviewed
Jun 27, 2025
barsukov
reviewed
Jun 30, 2025
ca48fd3
edda
reviewed
Jul 9, 2025
Contributor
edda
left a comment
There was a problem hiding this comment.
Thank you! I like it!
Two things I would propose:
- add the info form your comment with the justification for the encode/decode utility to the ADR itself. I think it's very valuable additional information that helps understand the decision. Also a simple example of what encode and decode does could help
- Section 5. Route Definitions and UI State: a couple of examples would help understand this better, imo. So give an example for one or two routes coming out of the file-based routing, then give an example how they would change with an opened panel or modal.
TilmanHaupt
previously approved these changes
Jul 10, 2025
9fa3770
edda
reviewed
Jul 10, 2025
Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>
edda
approved these changes
Jul 10, 2025
hodanoori
approved these changes
Jul 11, 2025
andypf
added a commit
that referenced
this pull request
Jul 29, 2025
* chore(docs): create ADR for client-side routing * chore(docs): add note for Tanstack router issue * chore(docs): add examples and url-state-provider background * chore(docs): update docs/decisions/004_client_side_routing.md Co-authored-by: Esther Schmitz <edda@users.noreply.github.com> * chore(docs): fix formatting --------- Co-authored-by: Andreas Pfau <andreas.pfau@sap.com> Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR add an ADR for client-side routing so other apps can add routing based on the same principals.
Changes Made
Related Issues
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.