Skip to content

chore(deps): upgrade license-checker-rseidelsohn to 4.4.2, fixing vulnerabilities#1102

Merged
guoda-puidokaite merged 13 commits intomainfrom
guoda-upgrade-lisence-checker
Jul 31, 2025
Merged

chore(deps): upgrade license-checker-rseidelsohn to 4.4.2, fixing vulnerabilities#1102
guoda-puidokaite merged 13 commits intomainfrom
guoda-upgrade-lisence-checker

Conversation

@guoda-puidokaite
Copy link
Copy Markdown
Contributor

@guoda-puidokaite guoda-puidokaite commented Jul 24, 2025

Summary

  • Upgrade license-checker-rseidelsohn to 4.4.2 (latest) and eslint to 9.31.0 (latest) to fix vulnerabilities linked below.

Notes for Carbon and Heureka:

  • There was 200+ eslint errors in Heureka. Therefore, all rules causing issues have been disabled until fixed.
  • There were only a few eslint issues in Carbon. Therefore, the rules remain enabled and in-line ignore lines have been added instead, so developers are flagged to fix them while working on those files. Some simple issues were also fixed.

Related Issues

Testing Instructions

Ensure no breaking changes.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@guoda-puidokaite guoda-puidokaite self-assigned this Jul 24, 2025
@guoda-puidokaite guoda-puidokaite requested a review from a team as a code owner July 24, 2025 12:32
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 24, 2025

🦋 Changeset detected

Latest commit: 7a2ead3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@cloudoperators/juno-config Patch
@cloudoperators/juno-app-template Patch
@cloudoperators/juno-app-heureka Patch
@cloudoperators/juno-app-carbon Patch
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@guoda-puidokaite guoda-puidokaite linked an issue Jul 24, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 24, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-07-31 13:45 UTC

andypf
andypf previously approved these changes Jul 24, 2025
@guoda-puidokaite guoda-puidokaite marked this pull request as draft July 30, 2025 08:47
@guoda-puidokaite guoda-puidokaite requested a review from andypf July 31, 2025 12:32
@guoda-puidokaite guoda-puidokaite marked this pull request as ready for review July 31, 2025 12:33
Copy link
Copy Markdown
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Copy Markdown
Contributor

@TilmanHaupt TilmanHaupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there already tasks to clean the ignores up?

Comment thread apps/carbon/eslint.config.mjs
@guoda-puidokaite
Copy link
Copy Markdown
Contributor Author

Thank You! Commented in our group chat flagging the ignores, let's create tickets.

@guoda-puidokaite guoda-puidokaite merged commit 1afa941 into main Jul 31, 2025
19 checks passed
@guoda-puidokaite guoda-puidokaite deleted the guoda-upgrade-lisence-checker branch July 31, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task](juno): Upgrade eslint to 9.31.0

3 participants