feat(heureka): implement initial filter URL sync and its filter pill deletion by hodanoori · Pull Request #1196 · cloudoperators/juno

hodanoori · 2025-10-07T16:52:23Z

Summary

This PR ensures that initial filters are properly added to deep links in Heureka, their pills are removable, and the filter state is correctly maintained when navigating between tabs.

Changes Made

Initial Filter Deep Linking: Initial filters from appProps.initialFilters are now automatically added to the URL when the app loads with no existing filters.
Removable Filter Pills: Initial filter pills can be deleted by clicking the close (X) button, and the URL is updated accordingly
Tab Navigation State Management: Added a React context store (InitialFiltersContext) to track whether initial filters have been applied during the browser session, preventing re-application when navigating between Services and Vulnerabilities tabs

Technical Implementation

Created InitialFiltersContext to manage initial filter application state across component lifecycle
Updated ServicesFilters component to use the context store instead of module-level variables
Integrated the context provider in the main App component
Maintained existing filter persistence mechanism for user-defined filters

Related Issues

Issue 1: closes [Task](heureka): Remove all filters including the initial filter #1012

Testing Instructions

1. Initial Filter Display

Open the app and navigate to the Services tab
You should see the initial filter in the URL: f_supportGroupCcrn=containers
The filter pill should be visible in the UI

2. Filter Deletion and Browser Reload

Delete the initial filter pill by clicking the X button
Reload the browser
The initial filter should reappear in both the URL and as a filter pill

3. Tab Navigation Without Re-application

Delete the initial filter pill
Switch to the Vulnerabilities tab
Switch back to the Services tab
The initial filter should NOT reappear (user deletion is respected)

4. Filter Persistence Between Tabs

Add custom filters to the Services tab
Switch to the Vulnerabilities tab and add different filters
Switch back to the Services tab
Your original Services filters should be preserved
Switch back to Vulnerabilities tab
Your original Vulnerabilities filters should be preserved
All filters should be visible as pills and reflected in the URL

Checklist

I have performed a self-review of my code.
I have commented my code, particularly in hard-to-understand areas.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.
I have made corresponding changes to the documentation (if applicable).
My changes generate no new warnings or errors.
I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

changeset-bot · 2025-10-07T16:52:27Z

🦋 Changeset detected

Latest commit: 3990197

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@cloudoperators/juno-app-greenhouse	Patch
@cloudoperators/juno-app-heureka	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-10-07T16:54:29Z

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-15 07:13 UTC

…vigation

Backend issue

guoda-puidokaite · 2025-10-13T08:02:22Z

I tested. From my understanding, looked good.

ArtieReus

Heureka: tested adding a wrong filter key. Expected to be ignored and show the initialfilters. Although the error will be catch in the upcoming PR it shouldn't happen an error from my point of view. f_supportGroupCcrns vs f_supportGroupCcrn

hodanoori · 2025-10-13T11:25:33Z

Heureka: tested adding a wrong filter key. Expected to be ignored and show the initialfilters. Although the error will be catch in the upcoming PR it shouldn't happen an error from my point of view. f_supportGroupCcrns vs f_supportGroupCcrn

This is addressed in Error handling PR from Taimoor that the app should not crash for such cases. Here is the PR:
#1197

ArtieReus

lgtm. As soon as the other concerns are addressed i can approve it

guoda-puidokaite · 2025-10-13T13:11:25Z

I'll test when resolved, ping.

…re uses

…component

taymoor89

Great stuff Hoda! 🏅

…deletion (#1196) * feat(heureka): makes initial filter pill removable * feat(heureka): adds store to track initial filter state across tab navigation * feat(heureka): adds changeset * fix(heureka): pretifies the files * fix(heureka): pretifies the files * fix(heureka): pretifies the files * fix(heureka): fixes prettier issue * fix(heureka): adjust services test * chore(heureka): renames store to StoreProvider to be generic for future uses * chore(heureka): corrects the comment * chore(heureka): improve store prop handling * chore(heureka): handles initialFilter store status in services route component * chore(heureka): fixes some leftovers

feat(heureka): makes initial filter pill removable

fcf93f4

hodanoori requested a review from a team as a code owner October 7, 2025 16:52

hodanoori self-assigned this Oct 7, 2025

Merge branch 'main' into hoda-heureka-handle-initial-filter

0745fc0

hodanoori marked this pull request as draft October 8, 2025 07:04

hodanoori and others added 2 commits October 9, 2025 16:45

Merge branch 'main' into hoda-heureka-handle-initial-filter

358e252

feat(heureka): adds store to track initial filter state across tab na…

d49ff8a

…vigation

hodanoori changed the title ~~feat(heureka): implements initial filter URL synchronization and its filter pill deletion~~ feat(heureka): implement initial filter URL sync and its filter pill deletion Oct 9, 2025

feat(heureka): adds changeset

84a1ba4

hodanoori marked this pull request as ready for review October 9, 2025 15:56

hodanoori added 5 commits October 10, 2025 09:17

fix(heureka): pretifies the files

254863c

fix(heureka): pretifies the files

21727a2

fix(heureka): pretifies the files

6f42b8d

fix(heureka): fixes prettier issue

a0e7315

fix(heureka): adjust services test

6ec0ffa

This comment was marked as off-topic.

Sign in to view

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into hoda-heureka-handle-initial-filter

527e222

guoda-puidokaite previously approved these changes Oct 13, 2025

View reviewed changes

taymoor89 requested changes Oct 13, 2025

View reviewed changes

Comment thread apps/heureka/src/store/InitialFiltersContext.tsx Outdated

Comment thread apps/heureka/src/routes/services/index.tsx Outdated

ArtieReus reviewed Oct 13, 2025

View reviewed changes

chore(heureka): renames store to StoreProvider to be generic for futu…

88836b4

…re uses

hodanoori dismissed guoda-puidokaite’s stale review via 88836b4 October 13, 2025 13:18

chore(heureka): corrects the comment

155cbca

hodanoori requested a review from taymoor89 October 13, 2025 13:42

taymoor89 reviewed Oct 13, 2025

View reviewed changes

Comment thread apps/heureka/src/components/Services/ServicesFilters.tsx Outdated

Comment thread apps/heureka/src/components/Services/ServicesFilters.tsx Outdated

Comment thread apps/heureka/src/components/Services/ServicesFilters.tsx Outdated

hodanoori added 3 commits October 13, 2025 16:27

chore(heureka): improve store prop handling

959c8ca

chore(heureka): handles initialFilter store status in services route …

d4ff3a9

…component

chore(heureka): fixes some leftovers

3990197

taymoor89 approved these changes Oct 13, 2025

View reviewed changes

ArtieReus approved these changes Oct 14, 2025

View reviewed changes

hodanoori merged commit f8b9234 into main Oct 15, 2025
16 checks passed

hodanoori deleted the hoda-heureka-handle-initial-filter branch October 15, 2025 07:11

Conversation

hodanoori commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Technical Implementation

Related Issues

Testing Instructions

1. Initial Filter Display

2. Filter Deletion and Browser Reload

3. Tab Navigation Without Re-application

4. Filter Persistence Between Tabs

Checklist

PR Manifesto

Uh oh!

changeset-bot Bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as resolved.

Uh oh!

guoda-puidokaite commented Oct 13, 2025

Uh oh!

Uh oh!

Uh oh!

ArtieReus left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hodanoori commented Oct 13, 2025

Uh oh!

ArtieReus left a comment

Choose a reason for hiding this comment

Uh oh!

guoda-puidokaite commented Oct 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

taymoor89 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hodanoori commented Oct 7, 2025 •

edited

Loading

changeset-bot Bot commented Oct 7, 2025 •

edited

Loading

github-actions Bot commented Oct 7, 2025 •

edited

Loading

ArtieReus left a comment •

edited

Loading