fix(heureka): gracefully handle fatal errors#1197
Conversation
🦋 Changeset detectedLatest commit: ec8a203 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
990d576 to
29ccff0
Compare
ArtieReus
left a comment
There was a problem hiding this comment.
Very good job I like how you have designed it. I just added 2 comments and one of them is about testing. Would it make sense at that stage at least for the new files introduced to add some tests?
355571c to
5f024be
Compare
hodanoori
left a comment
There was a problem hiding this comment.
Great work, thanks Taimoor. Please address the following case in this PR as well, as we discussed it this morning in our team round:
Display a loading indicator inside the filter selects while waiting for the GetServiceFilters request to complete, and if that request fails, show an appropriate “Failed to load filters” message inside Filter selects.
However, the services list should still render and remain usable (including search functionality and navigate to other panel or pages view).
465caaf to
bbdfa64
Compare
bbdfa64 to
d2d641b
Compare




Summary
Previously when there was a fatal error in case of broken API Heureka wasn't even displaying app layout. Now using ErrorBoundary the fatal errors that typically happen because of a rejected promise are gracefully handled and displayed inline.
Changes Made
MessagesProvideras it is not need at the moment.Related Issues
Screenshots (if applicable)
2025-10-08_11-55-10.mp4
2025-10-08_11-56-05.mp4
2025-10-08_11-57-23.mp4
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.