Skip to content

chore(heureka): replaces lodash with helper functions#1210

Merged
hodanoori merged 15 commits intohackathon-15-10-2025from
hackathon-remove-lodash
Oct 23, 2025
Merged

chore(heureka): replaces lodash with helper functions#1210
hodanoori merged 15 commits intohackathon-15-10-2025from
hackathon-remove-lodash

Conversation

@hodanoori
Copy link
Copy Markdown
Contributor

@hodanoori hodanoori commented Oct 15, 2025

Summary

As part of dependency management hackathon, this PR removes lodash from heureka and replaces it with custom utility functions to reduce bundle size and eliminate external dependencies.

Changes Made

  • Removed lodash dependency from package.json to reduce bundle size and eliminate external library dependency
  • Added custom utility functions to src/utils.ts including isEmpty, isNil, omit, mapObject, and map to replace commonly used lodash functions
  • Updated Services/utils.ts to import and use custom utility functions instead of lodash (isEmpty, isNil, omit)
  • Replaced lodash function calls throughout the codebase with native JavaScript implementations while maintaining the same API and functionality
  • Maintained backward compatibility by ensuring all replaced functions have identical behavior to their lodash counterparts

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. pnpm i
  2. pnpm TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@hodanoori hodanoori requested a review from a team as a code owner October 15, 2025 12:46
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 15, 2025

⚠️ No Changeset found

Latest commit: cbe1dff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hodanoori hodanoori changed the base branch from main to hackathon-15-10-2025 October 15, 2025 12:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 15, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://cloudoperators.github.io/juno/pr-preview/pr-1210/

Built to branch gh-pages at 2025-10-24 12:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

TilmanHaupt and others added 3 commits October 16, 2025 16:46
* chore(supernova): luxon killed in alertTimestamp

* chore(supernova): reduce luxon in alterttimestamp

* chore(supernova): reduce luxon

* chore(supernova): del luxon in statusbar

* chore(supernova): format statusbar

* chore(greenhouse): del luxon

* chore(greenhouse): del luxon
* remove wouter

* remove wouter from lock

* remove routing logiv

* remove routing logiv
* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
@hodanoori hodanoori requested a review from franzheidl as a code owner October 20, 2025 12:04
@hodanoori hodanoori force-pushed the hackathon-remove-lodash branch from cdf6e78 to 785fa13 Compare October 20, 2025 12:15
Comment thread apps/heureka/src/utils.ts Outdated
Copy link
Copy Markdown
Contributor

@taymoor89 taymoor89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for reducing one more dependency! 🥇

@taymoor89 taymoor89 force-pushed the hackathon-15-10-2025 branch from 2c78bab to 38b9138 Compare October 23, 2025 12:30
Resolved conflicts:
- Updated @tanstack/react-router to 1.133.22 in heureka and supernova
- Removed lodash dependency from heureka package.json
- Updated pnpm-lock.yaml with resolved dependencies
@hodanoori hodanoori merged commit 694c1f3 into hackathon-15-10-2025 Oct 23, 2025
11 checks passed
@hodanoori hodanoori deleted the hackathon-remove-lodash branch October 23, 2025 13:29
taymoor89 added a commit that referenced this pull request Oct 27, 2025
* chore(heureka): change timestamp

* chore(supernova): del luxon

* chore(supernova): redo date type

* chore(supernova): reduce luxon and delete luxon (#1213)

* chore(supernova): luxon killed in alertTimestamp

* chore(supernova): reduce luxon in alterttimestamp

* chore(supernova): reduce luxon

* chore(supernova): del luxon in statusbar

* chore(supernova): format statusbar

* chore(greenhouse): del luxon

* chore(greenhouse): del luxon

* chore(carbon): remove wouter (#1211)

* remove wouter

* remove wouter from lock

* remove routing logiv

* remove routing logiv

* chore(juno): fix conflicting versions (#1215)

* chore(core): remove classnames dep (#1216)

* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>

* chore(heureka): replaces lodash with helper functions (#1210)

* chore(heureka): change timestamp

* chore(supernova): del luxon

* chore(supernova): redo date type

* chore(heureka): replaces lodash with helper functions

* chore(heureka): removes types/lodash package as well

* chore(heureka): removes types/lodash package as well

* chore(heureka): adds lock file

* chore(supernova): reduce luxon and delete luxon (#1213)

* chore(supernova): luxon killed in alertTimestamp

* chore(supernova): reduce luxon in alterttimestamp

* chore(supernova): reduce luxon

* chore(supernova): del luxon in statusbar

* chore(supernova): format statusbar

* chore(greenhouse): del luxon

* chore(greenhouse): del luxon

* chore(carbon): remove wouter (#1211)

* remove wouter

* remove wouter from lock

* remove routing logiv

* remove routing logiv

* chore(juno): fix conflicting versions (#1215)

* chore(core): remove classnames dep (#1216)

* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>

* chore(heureka): removes map helper function

---------

Co-authored-by: TilmanHaupt <tilman.haupt@sap.com>
Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com>
Co-authored-by: Taimoor Aslam <taimoor.aslam@sap.com>
Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>

* chore(juno): add changeset

---------

Co-authored-by: TilmanHaupt <tilman.haupt@sap.com>
Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com>
Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>
Co-authored-by: Hoda <107242553+hodanoori@users.noreply.github.com>
taymoor89 added a commit that referenced this pull request Oct 28, 2025
* chore(heureka): change timestamp

* chore(supernova): del luxon

* chore(supernova): redo date type

* chore(supernova): reduce luxon and delete luxon (#1213)

* chore(supernova): luxon killed in alertTimestamp

* chore(supernova): reduce luxon in alterttimestamp

* chore(supernova): reduce luxon

* chore(supernova): del luxon in statusbar

* chore(supernova): format statusbar

* chore(greenhouse): del luxon

* chore(greenhouse): del luxon

* chore(carbon): remove wouter (#1211)

* remove wouter

* remove wouter from lock

* remove routing logiv

* remove routing logiv

* chore(juno): fix conflicting versions (#1215)

* chore(core): remove classnames dep (#1216)

* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>

* chore(heureka): replaces lodash with helper functions (#1210)

* chore(heureka): change timestamp

* chore(supernova): del luxon

* chore(supernova): redo date type

* chore(heureka): replaces lodash with helper functions

* chore(heureka): removes types/lodash package as well

* chore(heureka): removes types/lodash package as well

* chore(heureka): adds lock file

* chore(supernova): reduce luxon and delete luxon (#1213)

* chore(supernova): luxon killed in alertTimestamp

* chore(supernova): reduce luxon in alterttimestamp

* chore(supernova): reduce luxon

* chore(supernova): del luxon in statusbar

* chore(supernova): format statusbar

* chore(greenhouse): del luxon

* chore(greenhouse): del luxon

* chore(carbon): remove wouter (#1211)

* remove wouter

* remove wouter from lock

* remove routing logiv

* remove routing logiv

* chore(juno): fix conflicting versions (#1215)

* chore(core): remove classnames dep (#1216)

* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>

* chore(heureka): removes map helper function

---------

Co-authored-by: TilmanHaupt <tilman.haupt@sap.com>
Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com>
Co-authored-by: Taimoor Aslam <taimoor.aslam@sap.com>
Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>

* chore(juno): add changeset

---------

Co-authored-by: TilmanHaupt <tilman.haupt@sap.com>
Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com>
Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>
Co-authored-by: Hoda <107242553+hodanoori@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants