chore(heureka): replaces lodash with helper functions#1210
Merged
hodanoori merged 15 commits intohackathon-15-10-2025from Oct 23, 2025
Merged
chore(heureka): replaces lodash with helper functions#1210hodanoori merged 15 commits intohackathon-15-10-2025from
hodanoori merged 15 commits intohackathon-15-10-2025from
Conversation
|
Contributor
|
* chore(supernova): luxon killed in alertTimestamp * chore(supernova): reduce luxon in alterttimestamp * chore(supernova): reduce luxon * chore(supernova): del luxon in statusbar * chore(supernova): format statusbar * chore(greenhouse): del luxon * chore(greenhouse): del luxon
* remove wouter * remove wouter from lock * remove routing logiv * remove routing logiv
* chore(carbon): remove classnames dependency * chore(carbon): refactor classnames usage to vanilla js --------- Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
cdf6e78 to
785fa13
Compare
TilmanHaupt
approved these changes
Oct 21, 2025
taymoor89
reviewed
Oct 23, 2025
taymoor89
approved these changes
Oct 23, 2025
Contributor
taymoor89
left a comment
There was a problem hiding this comment.
LGTM, thanks for reducing one more dependency! 🥇
2c78bab to
38b9138
Compare
Resolved conflicts: - Updated @tanstack/react-router to 1.133.22 in heureka and supernova - Removed lodash dependency from heureka package.json - Updated pnpm-lock.yaml with resolved dependencies
taymoor89
added a commit
that referenced
this pull request
Oct 27, 2025
* chore(heureka): change timestamp * chore(supernova): del luxon * chore(supernova): redo date type * chore(supernova): reduce luxon and delete luxon (#1213) * chore(supernova): luxon killed in alertTimestamp * chore(supernova): reduce luxon in alterttimestamp * chore(supernova): reduce luxon * chore(supernova): del luxon in statusbar * chore(supernova): format statusbar * chore(greenhouse): del luxon * chore(greenhouse): del luxon * chore(carbon): remove wouter (#1211) * remove wouter * remove wouter from lock * remove routing logiv * remove routing logiv * chore(juno): fix conflicting versions (#1215) * chore(core): remove classnames dep (#1216) * chore(carbon): remove classnames dependency * chore(carbon): refactor classnames usage to vanilla js --------- Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com> * chore(heureka): replaces lodash with helper functions (#1210) * chore(heureka): change timestamp * chore(supernova): del luxon * chore(supernova): redo date type * chore(heureka): replaces lodash with helper functions * chore(heureka): removes types/lodash package as well * chore(heureka): removes types/lodash package as well * chore(heureka): adds lock file * chore(supernova): reduce luxon and delete luxon (#1213) * chore(supernova): luxon killed in alertTimestamp * chore(supernova): reduce luxon in alterttimestamp * chore(supernova): reduce luxon * chore(supernova): del luxon in statusbar * chore(supernova): format statusbar * chore(greenhouse): del luxon * chore(greenhouse): del luxon * chore(carbon): remove wouter (#1211) * remove wouter * remove wouter from lock * remove routing logiv * remove routing logiv * chore(juno): fix conflicting versions (#1215) * chore(core): remove classnames dep (#1216) * chore(carbon): remove classnames dependency * chore(carbon): refactor classnames usage to vanilla js --------- Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com> * chore(heureka): removes map helper function --------- Co-authored-by: TilmanHaupt <tilman.haupt@sap.com> Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com> Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com> Co-authored-by: Taimoor Aslam <taimoor.aslam@sap.com> Co-authored-by: Esther Schmitz <edda@users.noreply.github.com> * chore(juno): add changeset --------- Co-authored-by: TilmanHaupt <tilman.haupt@sap.com> Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com> Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com> Co-authored-by: Esther Schmitz <edda@users.noreply.github.com> Co-authored-by: Hoda <107242553+hodanoori@users.noreply.github.com>
taymoor89
added a commit
that referenced
this pull request
Oct 28, 2025
* chore(heureka): change timestamp * chore(supernova): del luxon * chore(supernova): redo date type * chore(supernova): reduce luxon and delete luxon (#1213) * chore(supernova): luxon killed in alertTimestamp * chore(supernova): reduce luxon in alterttimestamp * chore(supernova): reduce luxon * chore(supernova): del luxon in statusbar * chore(supernova): format statusbar * chore(greenhouse): del luxon * chore(greenhouse): del luxon * chore(carbon): remove wouter (#1211) * remove wouter * remove wouter from lock * remove routing logiv * remove routing logiv * chore(juno): fix conflicting versions (#1215) * chore(core): remove classnames dep (#1216) * chore(carbon): remove classnames dependency * chore(carbon): refactor classnames usage to vanilla js --------- Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com> * chore(heureka): replaces lodash with helper functions (#1210) * chore(heureka): change timestamp * chore(supernova): del luxon * chore(supernova): redo date type * chore(heureka): replaces lodash with helper functions * chore(heureka): removes types/lodash package as well * chore(heureka): removes types/lodash package as well * chore(heureka): adds lock file * chore(supernova): reduce luxon and delete luxon (#1213) * chore(supernova): luxon killed in alertTimestamp * chore(supernova): reduce luxon in alterttimestamp * chore(supernova): reduce luxon * chore(supernova): del luxon in statusbar * chore(supernova): format statusbar * chore(greenhouse): del luxon * chore(greenhouse): del luxon * chore(carbon): remove wouter (#1211) * remove wouter * remove wouter from lock * remove routing logiv * remove routing logiv * chore(juno): fix conflicting versions (#1215) * chore(core): remove classnames dep (#1216) * chore(carbon): remove classnames dependency * chore(carbon): refactor classnames usage to vanilla js --------- Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com> * chore(heureka): removes map helper function --------- Co-authored-by: TilmanHaupt <tilman.haupt@sap.com> Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com> Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com> Co-authored-by: Taimoor Aslam <taimoor.aslam@sap.com> Co-authored-by: Esther Schmitz <edda@users.noreply.github.com> * chore(juno): add changeset --------- Co-authored-by: TilmanHaupt <tilman.haupt@sap.com> Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com> Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com> Co-authored-by: Esther Schmitz <edda@users.noreply.github.com> Co-authored-by: Hoda <107242553+hodanoori@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of dependency management hackathon, this PR removes lodash from heureka and replaces it with custom utility functions to reduce bundle size and eliminate external dependencies.
Changes Made
Related Issues
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.