Skip to content

chore(core): remove classnames dep#1216

Merged
TilmanHaupt merged 3 commits intohackathon-15-10-2025from
remove-classnames-dep
Oct 19, 2025
Merged

chore(core): remove classnames dep#1216
TilmanHaupt merged 3 commits intohackathon-15-10-2025from
remove-classnames-dep

Conversation

@edda
Copy link
Copy Markdown
Contributor

@edda edda commented Oct 15, 2025 •
edited
Loading

Summary

This PR removes the classnames dependency as it was only used in one place in the carbon app.

Changes Made

  • Removed dependency
  • Replaced classnames usage

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. pnpm i
  2. pnpm TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@edda edda requested a review from a team as a code owner October 15, 2025 12:59
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a349753

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 15, 2025 •
edited
Loading

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-19 08:52 UTC

@edda edda changed the base branch from main to hackathon-15-10-2025 October 15, 2025 13:00
@TilmanHaupt TilmanHaupt changed the title chore(deps): Remove classnames dep chore(deps): remove classnames dep Oct 19, 2025
@TilmanHaupt TilmanHaupt changed the title chore(deps): remove classnames dep chore(core): remove classnames dep Oct 19, 2025
@TilmanHaupt TilmanHaupt assigned TilmanHaupt and edda and unassigned TilmanHaupt Oct 19, 2025
@TilmanHaupt TilmanHaupt merged commit 2c78bab into hackathon-15-10-2025 Oct 19, 2025
13 checks passed
@TilmanHaupt TilmanHaupt deleted the remove-classnames-dep branch October 19, 2025 08:52
hodanoori pushed a commit that referenced this pull request Oct 20, 2025
@edda @TilmanHaupt @hodanoori
chore(core): remove classnames dep (#1216)
cdf6e78 
* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
taymoor89 pushed a commit that referenced this pull request Oct 23, 2025
@edda @TilmanHaupt @taymoor89
chore(core): remove classnames dep (#1216)
38b9138 
* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
hodanoori added a commit that referenced this pull request Oct 23, 2025
@hodanoori @TilmanHaupt
@guoda-puidokaite @taymoor89 @edda
chore(heureka): replaces lodash with helper functions (#1210)
694c1f3 
* chore(heureka): change timestamp

* chore(supernova): del luxon

* chore(supernova): redo date type

* chore(heureka): replaces lodash with helper functions

* chore(heureka): removes types/lodash package as well

* chore(heureka): removes types/lodash package as well

* chore(heureka): adds lock file

* chore(supernova): reduce luxon and delete luxon (#1213)

* chore(supernova): luxon killed in alertTimestamp

* chore(supernova): reduce luxon in alterttimestamp

* chore(supernova): reduce luxon

* chore(supernova): del luxon in statusbar

* chore(supernova): format statusbar

* chore(greenhouse): del luxon

* chore(greenhouse): del luxon

* chore(carbon): remove wouter (#1211)

* remove wouter

* remove wouter from lock

* remove routing logiv

* remove routing logiv

* chore(juno): fix conflicting versions (#1215)

* chore(core): remove classnames dep (#1216)

* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>

* chore(heureka): removes map helper function

---------

Co-authored-by: TilmanHaupt <tilman.haupt@sap.com>
Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com>
Co-authored-by: Taimoor Aslam <taimoor.aslam@sap.com>
Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>
taymoor89 added a commit that referenced this pull request Oct 27, 2025
@taymoor89 @TilmanHaupt
@guoda-puidokaite @edda @hodanoori
chore(juno): dependencies management hackathon 15.10.2025 (#1250)
f82caaa 
* chore(heureka): change timestamp

* chore(supernova): del luxon

* chore(supernova): redo date type

* chore(supernova): reduce luxon and delete luxon (#1213)

* chore(supernova): luxon killed in alertTimestamp

* chore(supernova): reduce luxon in alterttimestamp

* chore(supernova): reduce luxon

* chore(supernova): del luxon in statusbar

* chore(supernova): format statusbar

* chore(greenhouse): del luxon

* chore(greenhouse): del luxon

* chore(carbon): remove wouter (#1211)

* remove wouter

* remove wouter from lock

* remove routing logiv

* remove routing logiv

* chore(juno): fix conflicting versions (#1215)

* chore(core): remove classnames dep (#1216)

* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>

* chore(heureka): replaces lodash with helper functions (#1210)

* chore(heureka): change timestamp

* chore(supernova): del luxon

* chore(supernova): redo date type

* chore(heureka): replaces lodash with helper functions

* chore(heureka): removes types/lodash package as well

* chore(heureka): removes types/lodash package as well

* chore(heureka): adds lock file

* chore(supernova): reduce luxon and delete luxon (#1213)

* chore(supernova): luxon killed in alertTimestamp

* chore(supernova): reduce luxon in alterttimestamp

* chore(supernova): reduce luxon

* chore(supernova): del luxon in statusbar

* chore(supernova): format statusbar

* chore(greenhouse): del luxon

* chore(greenhouse): del luxon

* chore(carbon): remove wouter (#1211)

* remove wouter

* remove wouter from lock

* remove routing logiv

* remove routing logiv

* chore(juno): fix conflicting versions (#1215)

* chore(core): remove classnames dep (#1216)

* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>

* chore(heureka): removes map helper function

---------

Co-authored-by: TilmanHaupt <tilman.haupt@sap.com>
Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com>
Co-authored-by: Taimoor Aslam <taimoor.aslam@sap.com>
Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>

* chore(juno): add changeset

---------

Co-authored-by: TilmanHaupt <tilman.haupt@sap.com>
Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com>
Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>
Co-authored-by: Hoda <107242553+hodanoori@users.noreply.github.com>
taymoor89 added a commit that referenced this pull request Oct 28, 2025
@taymoor89 @TilmanHaupt
@guoda-puidokaite @edda @hodanoori
chore(juno): dependencies management hackathon 15.10.2025 (#1250)
5fc0660 
* chore(heureka): change timestamp

* chore(supernova): del luxon

* chore(supernova): redo date type

* chore(supernova): reduce luxon and delete luxon (#1213)

* chore(supernova): luxon killed in alertTimestamp

* chore(supernova): reduce luxon in alterttimestamp

* chore(supernova): reduce luxon

* chore(supernova): del luxon in statusbar

* chore(supernova): format statusbar

* chore(greenhouse): del luxon

* chore(greenhouse): del luxon

* chore(carbon): remove wouter (#1211)

* remove wouter

* remove wouter from lock

* remove routing logiv

* remove routing logiv

* chore(juno): fix conflicting versions (#1215)

* chore(core): remove classnames dep (#1216)

* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>

* chore(heureka): replaces lodash with helper functions (#1210)

* chore(heureka): change timestamp

* chore(supernova): del luxon

* chore(supernova): redo date type

* chore(heureka): replaces lodash with helper functions

* chore(heureka): removes types/lodash package as well

* chore(heureka): removes types/lodash package as well

* chore(heureka): adds lock file

* chore(supernova): reduce luxon and delete luxon (#1213)

* chore(supernova): luxon killed in alertTimestamp

* chore(supernova): reduce luxon in alterttimestamp

* chore(supernova): reduce luxon

* chore(supernova): del luxon in statusbar

* chore(supernova): format statusbar

* chore(greenhouse): del luxon

* chore(greenhouse): del luxon

* chore(carbon): remove wouter (#1211)

* remove wouter

* remove wouter from lock

* remove routing logiv

* remove routing logiv

* chore(juno): fix conflicting versions (#1215)

* chore(core): remove classnames dep (#1216)

* chore(carbon): remove classnames dependency

* chore(carbon): refactor classnames usage to vanilla js

---------

Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>

* chore(heureka): removes map helper function

---------

Co-authored-by: TilmanHaupt <tilman.haupt@sap.com>
Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com>
Co-authored-by: Taimoor Aslam <taimoor.aslam@sap.com>
Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>

* chore(juno): add changeset

---------

Co-authored-by: TilmanHaupt <tilman.haupt@sap.com>
Co-authored-by: Tilman <147151040+TilmanHaupt@users.noreply.github.com>
Co-authored-by: Guoda <121792659+guoda-puidokaite@users.noreply.github.com>
Co-authored-by: Esther Schmitz <edda@users.noreply.github.com>
Co-authored-by: Hoda <107242553+hodanoori@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TilmanHaupt TilmanHaupt TilmanHaupt approved these changes

Assignees

@edda edda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edda @TilmanHaupt