refactor: move toolchain from root to pkg/toolchain #2041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
added
the
no-release
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Move the toolchain package from the repository root to pkg/toolchain to align with project architecture guidelines. All business logic belongs in pkg/ - no packages should exist at the repo root level. Changes: - Move 94 Go files from toolchain/ to pkg/toolchain/ (preserves git history) - Update 90 import statements across 145 files to reference github.com/cloudposse/atmos/pkg/toolchain - Regenerate mocks with updated import paths - Update documentation references This ensures consistency with other business logic packages (config, stack, component, store, git, auth, etc.). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
osterman
force-pushed
the
osterman/toolchain-root-issue
branch
from
94fe277 to
3cc84b8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2041 +/- ##
=======================================
Coverage 75.55% 75.55%
=======================================
Files 793 793
Lines 73718 73718
=======================================
+ Hits 55698 55699 +1
+ Misses 14526 14524 -2
- Partials 3494 3495 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
aknysh
approved these changes
Jan 30, 2026
Contributor
📝 WalkthroughWalkthroughThis PR updates import paths across the codebase, moving all toolchain package imports from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
These changes were released in v1.205.1-rc.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
pkg/toolchainto align with project architecture guidelinesgithub.com/cloudposse/atmos/pkg/toolchainwhy
The toolchain package was incorrectly placed at the repository root in PR #1686. Project architecture guidelines (CLAUDE.md) specify that all business logic packages belong in
pkg/. Moving toolchain topkg/toolchainensures consistency with other business logic packages like config, stack, component, store, git, and auth.references
Aligns with project architecture guidelines in CLAUDE.md: All business logic belongs in
pkg/packages, not at the repository root.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.