Conversation
…escribe affected Agent-Logs-Url: https://github.com/cloudposse/atmos/sessions/247337de-2a29-4144-917f-2eb321659700 Co-authored-by: osterman <52489+osterman@users.noreply.github.com>
…nd add specific component assertions in test Agent-Logs-Url: https://github.com/cloudposse/atmos/sessions/247337de-2a29-4144-917f-2eb321659700 Co-authored-by: osterman <52489+osterman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve error message for atmos describe affected
fix: treat missing Atmos config in BASE as empty baseline in Apr 7, 2026
atmos describe affected
Dependency Review✅ No vulnerabilities or license issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
=======================================
Coverage 77.24% 77.25%
=======================================
Files 1074 1074
Lines 101900 101910 +10
=======================================
+ Hits 78716 78730 +14
+ Misses 18846 18837 -9
- Partials 4338 4343 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
aknysh
approved these changes
Apr 13, 2026
Contributor
|
These changes were released in v1.216.0-rc.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atmos describe affectedfatally errors withfailed to find importon greenfield branches (or when the base ref predates Atmos adoption) becauseErrFailedToFindImportfrom BASE stack processing was propagated as a hard failure. The correct behavior is to treat an unconfigured BASE as an empty baseline — everything in HEAD is new, therefore everything is affected.Changes
internal/exec/describe_affected_utils.go—executeDescribeAffectednow handlesErrFailedToFindImportalongsideErrNoStackManifestsFoundin both BASE processing paths:FindAllStackConfigsInPathsForStackreturningErrFailedToFindImport(stacks directory absent in BASE) → setsremoteStackConfigFilesAbsolutePaths = []string{}ExecuteDescribeStacksreturningErrFailedToFindImport(imports unresolvable in BASE) → setsremoteStacks = map[string]any{}Both cases emit a
WARNlog with actionable context:tests/describe_affected_greenfield_test.go— Integration test that initializes a bare-minimum git repo (single commit, no Atmos config) as the BASE and asserts all known HEAD components (component-1,component-2inprod/nonprod) appear in the affected output without error.