fix(ci): fire CI hooks per-component in apply --all mode (#2475)

[thejrose1984]

Extends the per-component CI hook pattern from PR #2430 (plan --all) to apply --all, so each component produces its own CI summary entry instead of a single misattributed entry for the last component.

what

• Update apply --all to fire per-component CI hooks.
• Preserve per-component CI reporting semantics used by plan --all.

why

• Prevent CI summaries from being misattributed to only the last component.
• Ensure each component has its own hook and status entry in CI pipelines.

references

• Fixes behavior introduced in PR fix(ci): fire CI hooks per-component in --all / --query plan mode (#2… #2430 for plan --all.
• Addresses CI reporting bug for apply --all mode.

Summary by CodeRabbit

• Bug Fixes

  • Prevented duplicate CI hook firing during multi-component Terraform apply runs.
  • Reset per-run state at apply start so deferred and post-run hooks observe consistent values.
  • Suppressed post-run hook execution for multi-component apply to avoid double execution.

• Tests

  • Added tests covering CI hook handling and post-run suppression in multi-component apply scenarios.

[atmos-pro]

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More.

[coderabbitai]

📝 Walkthrough

Walkthrough

Resets per-run state at apply start, suppresses global deferred/PostRunE hooks during multi-component (--all) runs, and adds per-component CI-hook invocation for Terraform apply; tests cover wrapper invocation, PostRunE suppression, and exit-code forwarding.

Changes

Multi-component apply CI hooks

Layer / File(s)	Summary
Global hook suppression for multi-component runs cmd/terraform/apply.go	Per-run state resets capturedApplyOutput and wasMultiComponentExecution at RunE start. Deferred error-hook invocation is conditioned on runErr != nil && !wasMultiComponentExecution. PostRunE returns nil immediately when wasMultiComponentExecution is true.
Per-component apply hook implementation and wiring cmd/terraform/utils.go	Adds runCIHooksForApplyComponent to initialize CLI config and call h.RunCIHooks with AfterTerraformApply, passing stripped component output and derived exit code. terraformRunWithOptions sets info.PerComponentHook to this helper for apply subcommands in multi-component mode.
Apply component hook test coverage cmd/terraform/utils_hooks_test.go	Adds tests: TestRunCIHooksForApplyComponent_DemoStacks, TestApplyPostRunE_SuppressedWhenMultiComponent, and TestRunCIHooksForApplyComponent_ExitCodeForwarding to validate wrapper invocation, PostRunE suppression, and exit-code forwarding across success and error paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• Bug: CI hooks fire only once in --all mode, producing summary for last component only #2475: Addresses the same per-component CI hook invocation pattern for multi-component runs by resetting state and suppressing global hooks.
• Bug: CI hooks fire only once in deploy --all mode, producing summary for last component only #2476: Mirrors the multi-component CI-hook wiring pattern noted for missing apply behavior in that issue.

Possibly related PRs

• cloudposse/atmos#2430: Establishes the multi-component CI-hook sentinel pattern with wasMultiComponentExecution and per-component hook wiring that this PR extends from plan to apply mode.
• cloudposse/atmos#2382: Introduces CI hook options and exit-code forwarding that the new apply hook handler relies on.

Suggested labels

patch

Suggested reviewers

• aknysh
• goruha

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: extending per-component CI hook firing to apply --all mode, matching the PR's core objective.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cmd/terraform/utils_hooks_test.go`:
- Around line 184-196: The test builds a command via newHookTestCmd() which
creates a command with Use: "plan", but the test invokes applyCmd.PostRunE,
causing a mismatch; update the test so the command identity matches apply:
either create a new helper/newHookTestCmd that accepts a use-name and call
newHookTestCmd("apply"), or set cmd.Use = "apply" on the returned command before
calling applyCmd.PostRunE(cmd, ...), ensuring newHookTestCmd(),
applyCmd.PostRunE, and the cmd variable reflect the "apply" command identity.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1955e1b9-f0a4-4dba-88fa-dc88cc33c577

📥 Commits

Reviewing files that changed from the base of the PR and between 357464e and 3387ad4.

📒 Files selected for processing (3)

• cmd/terraform/apply.go
• cmd/terraform/utils.go
• cmd/terraform/utils_hooks_test.go

[coderabbitai]

🧹 Nitpick comments (1)

cmd/terraform/utils_hooks_test.go (1)

156-198: ⚡ Quick win

Initialize cmd.NewTestKit(t) in these new cmd tests.

Please add cmd.NewTestKit(t) at the start of each new test here so command/root state cleanup is consistent with repo test conventions.

As per coding guidelines "cmd/**/*_test.go: ALWAYS use cmd.NewTestKit(t) for cmd tests to auto-clean RootCmd state (flags, args)."

Also applies to: 203-232

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/terraform/utils_hooks_test.go` around lines 156 - 198, The tests
TestRunCIHooksForApplyComponent_DemoStacks and
TestApplyPostRunE_SuppressedWhenMultiComponent need to call cmd.NewTestKit(t) at
the start to ensure RootCmd state is reset between tests; add a
cmd.NewTestKit(t) invocation as the first statement in each of these test
functions (before t.Chdir and before creating cmd via newHookTestCmd()), so
command/root flags and args are auto-cleaned for tests that exercise
newHookTestCmd(), applyCmd.PostRunE and the wasMultiComponentExecution logic.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@cmd/terraform/utils_hooks_test.go`:
- Around line 156-198: The tests TestRunCIHooksForApplyComponent_DemoStacks and
TestApplyPostRunE_SuppressedWhenMultiComponent need to call cmd.NewTestKit(t) at
the start to ensure RootCmd state is reset between tests; add a
cmd.NewTestKit(t) invocation as the first statement in each of these test
functions (before t.Chdir and before creating cmd via newHookTestCmd()), so
command/root flags and args are auto-cleaned for tests that exercise
newHookTestCmd(), applyCmd.PostRunE and the wasMultiComponentExecution logic.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6a640242-3b5c-49cf-81a5-712501a1d528

📥 Commits

Reviewing files that changed from the base of the PR and between 1984411 and a7781e8.

📒 Files selected for processing (3)

• cmd/terraform/apply.go
• cmd/terraform/utils.go
• cmd/terraform/utils_hooks_test.go

[codecov]

Codecov Report

❌ Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.24%. Comparing base (a0cd286) to head (f621d07).

Files with missing lines	Patch %	Lines
cmd/terraform/utils.go	61.90%	6 Missing and 2 partials ⚠️
cmd/terraform/apply.go	75.00%	0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (64.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2477      +/-   ##
==========================================
+ Coverage   78.21%   78.24%   +0.03%     
==========================================
  Files        1119     1119              
  Lines      106243   106266      +23     
==========================================
+ Hits        83095    83148      +53     
+ Misses      18509    18483      -26     
+ Partials     4639     4635       -4     

Flag	Coverage Δ
unittests	78.24% <64.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
cmd/terraform/apply.go	78.18% <75.00%> (+0.82%)	⬆️
cmd/terraform/utils.go	55.45% <61.90%> (+0.41%)	⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[thejrose1984]

Status summary for maintainers

Code state: CodeRabbit APPROVED at the current HEAD f621d070. Full CI matrix has already run — Tests, Build (linux/macos/windows), Acceptance Tests, CodeQL, golangci-lint, Hadolint, and all [mock-*]/[validate] jobs pass.

What's blocking merge:

1. autofix (atmos.ci) failure — fork-PR infrastructure limitation. The autofix steps (gofumpt, pre-commit whitespace, NOTICE generation, HCL fmt, README regen) all ran successfully. The Commit fixes via Atmos Pro step then failed because Atmos Pro cannot push back to the fork branch. I verified locally with gofumpt/goimports/trailing-whitespace that no actual Go-source changes are needed. maintainerCanModify is true on this PR, so a maintainer can push the autofix changes (if any) directly, or this check needs to be excluded from required status checks for fork PRs.
2. Missing patch semver label. PR Semver Labels fails because no semver label is set, and I lack AddLabelsToLabelable permission. This is a bug fix (issue Bug: CI hooks fire only once in --all mode, producing summary for last component only #2475) so patch is appropriate.
3. Human review. Branch protection requires a maintainer review beyond CodeRabbit's bot approval.

Re: the inline nitpick about cmd.NewTestKit(t) — I responded above explaining why it doesn't apply in cmd/terraform (TestKit is in package cmd, not exported across subpackages; CodeRabbit's own prior learning from #1808 confirms this).

[Andriy Knysh (aknysh)]

thanks thejrose1984

[atmos-pro]

Note

Atmos Pro  

Waiting for your GitHub Actions workflow to upload affected stacks.
Learn More.

[github-actions]

These changes were released in v1.220.0-rc.1.