fix(ci): repair Docker build and Homebrew formula bump in release workflow#2525
Conversation
…kflow The kustomize install script has known bugs (kubernetes-sigs/kustomize#5562) causing tar extraction failures. Replace with direct download pinned to v5.8.1. The mislav/bump-homebrew-formula-action is broken by GitHub returning HTTP 303 instead of 302 for tarball redirects (mislav/bump-homebrew-formula-action#340). Replace with dawidd6/action-homebrew-bump-formula@v7 which uses `brew bump-formula-pr` and properly follows redirects. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files
|
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates two build infrastructure dependencies. The Homebrew formula bump step is upgraded to a newer action that handles GitHub HTTP redirects correctly, and the Kustomize installation is simplified by replacing a script with a direct pinned download with cross-architecture support. ChangesBuild and Release Infrastructure Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CodeRabbit (@coderabbitai) review if the changes in the PR are correct |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
echo "=== Dockerfile ==="
cat Dockerfile
echo ""
echo "=== .github/workflows/build.yml ==="
cat .github/workflows/build.ymlLength of output: 5256 🌐 Web query:
Length of output: 6129 🌐 Web query:
Length of output: 13353 🌐 Web query:
Length of output: 12883
Dockerfile — Kustomize install
One minor note: the Workflow — Homebrew formula bump
The homebrew-core formula even has Both fixes are solid. The PR correctly addresses the two root causes (kustomize script tar bug, and the HTTP 303 redirect issue with the old Homebrew action). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2525 +/- ##
==========================================
+ Coverage 78.54% 78.56% +0.02%
==========================================
Files 1143 1143
Lines 109834 109834
==========================================
+ Hits 86266 86288 +22
+ Misses 18783 18757 -26
- Partials 4785 4789 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
|
These changes were released in v1.220.0-rc.4. |
what
install_kustomize.shscript in the Dockerfile with a direct download from GitHub Releases, pinned to kustomize v5.8.1mislav/bump-homebrew-formula-action@v3withdawidd6/action-homebrew-bump-formula@v7(SHA-pinned) for the Homebrew formula bump stepwhy
tar: ./kustomize_v*_linux_amd64.tar.gz: Cannot open) during Docker image buildsmislav/bump-homebrew-formula-actionis broken because GitHub now returns HTTP 303 instead of 302 for tarball redirects, and the action hardcodesstatusCode == 302(mislav/bump-homebrew-formula-action#340, open/unfixed)references
Summary by CodeRabbit