Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0949bdfb02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Plan the run with `atmos terraform plan account -s core-gbl-root` | ||
| - Check that `stacks/catalog/aws-account/defaults.yaml` has the values you expect, especially account email format | ||
| - Run `atmos describe component aws-account/core-artifacts -s core-gbl-root` to inspect the final component configuration (e.g. _after_ all the mixins have been imported) | ||
| - Plan the run with `atmos terraform plan aws-account/core-artifacts -s core-gbl-root` |
There was a problem hiding this comment.
Move the initial
aws-account plan after OU deployment
This checklist now tells readers to run atmos terraform plan aws-account/core-artifacts -s core-gbl-root before the organization and OU workflows have run, but the same page later says the aws-account/* components read OU IDs from aws-organizational-unit/* via !terraform.state (docs/layers/accounts/deploy-accounts.mdx, lines 84-88). On a fresh quickstart setup there is no OU state yet, so this "validation" step will fail and block the documented flow instead of helping users verify their account config.
Useful? React with 👍 / 👎.
This pull request updates the AWS accounts deployment guide and related workflow examples to improve clarity, accuracy, and alignment with the current reference architecture. The changes modernize the step-by-step instructions, clarify the use of instanced components, and update workflow commands and file references to match the latest best practices.
Documentation and workflow improvements:
aws-account-settings). [1] [2]