feat: Enable additional CloudFront real-time metrics Jakub Wądołowski (@jwadolowski) (#372)
## whatAdd additional_metrics_enabled variable (default: false for backwards compatibility) that provisions an aws_cloudfront_monitoring_subscription resource when enabled.
why
Not all CloudFront metrics are enabled by default. Some (4xx/5xx error rates by HTTP status code, origin latency, and cache hit rate) are hidden behind a monitoring subscription. This adds a convenient switch to enable them when needed.
The realtime_metrics_subscription_status value could have been derived from var.additional_metrics_enabled, but that would introduce an unexpected resource change across all existing deployments.
references
A complementary PR to cloudposse/terraform-aws-cloudfront-cdn#162
docs: web acl id can be an ARN for newer WAFs yangci (@oycyc) (#349)
As per the AWS provider docs. Updating description here so consumers don't get confused why WAF association fails when providing the ID.ID or ARN of the AWS WAF web ACL that is associated with the distribution. NOTE: If using the latest version of WAF (WAFv2), be sure to use the ARN. If using WAF Classic, use the ID. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudfront_distribution#web_acl_id-3
