Support additional attributes and secondary indexes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamie-BitFlight
changed the title
osterman
changed the title
osterman
reviewed
May 17, 2018
| Only define attributes on the table object that are going to be used as: | ||
|
|
||
| * Table hash key or range key | ||
| * LSI or GSI hash key or range key |
osterman
reviewed
May 17, 2018
README.md
Outdated
| | `global_secondary_index_map` | `[]` | List of maps, that describes additional secondary index properties | No | | ||
|
|
||
|
|
||
| ## A note about dynamodb attributes |
Member
There was a problem hiding this comment.
Use proper capitalization for DynamoDB
osterman
reviewed
May 17, 2018
README.md
Outdated
| | `autoscale_min_write_capacity` | `5` | DynamoDB autoscaling min write capacity | No | | ||
| | `autoscale_max_write_capacity` | `20` | DynamoDB autoscaling max write capacity | No | | ||
| | `enable_autoscaler` | `true` | Flag to enable/disable DynamoDB autoscaling | No | | ||
| | `dynamodb_attributes` | `[]` | List of maps, that describe extra dynamodb attributes | No | |
Member
There was a problem hiding this comment.
...extra DynamoDB attributes...
Contributor
Author
|
Will address. |
Closed
aknysh
approved these changes
May 19, 2018
Member
aknysh
left a comment
aknysh
left a comment
There was a problem hiding this comment.
@Jamie-BitFlight
I tested your changes without the new attributes/indexes (for compatibility) and with the new attributes/indexes.
Everything worked.
Thanks for your contribution.
(I'll try to review all other PRs this weekend).
Contributor
Author
|
Great :) |
Member
|
Thanks @ankysh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what