fix: Update arrow-go to v18.7.0 and preserve int64 precision in nested values - #23228
Closed
erezrokah wants to merge 3 commits into
Closed
fix: Update arrow-go to v18.7.0 and preserve int64 precision in nested values#23228erezrokah wants to merge 3 commits into
erezrokah wants to merge 3 commits into
Conversation
github-actions
Bot
added
area/cli
area/plugin/source/hackernews
area/plugin/destination/gremlin
area/plugin/destination/snowflake
area/plugin/destination/gcs
area/plugin/destination/s3
area/plugin/destination/mongodb
area/plugin/destination/kafka
area/plugin/destination/sqlite
area/plugin/destination/postgresql
area/plugin/destination/mysql
area/plugin/destination/mssql
area/plugin/destination/neo4j
area/plugin/destination/duckdb
area/plugin/destination/elasticsearch
area/plugin/destination/bigquery
area/plugin/destination/azblob
area/plugin/destination/clickhouse
area/plugin/destination/file
area/plugin/destination/firehose
area/plugin/destination/meilisearch
area/scaffold
area/plugin/destination/test
area/plugin/source/test
area/plugin/destination/sqlite-python
labels
erezrokah
force-pushed
the
claude/arrow-18.7-int64
branch
from
August 3, 2026 15:08
b833136 to
3621d9b
Compare
Member
Author
|
Moved the fix into #23163 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #23163.
arrow-go v18.7.0 made
array.FromJSONdecode int64/uint64 exactly, butAppendValueFromStringstill routes nested values through float64, so list/struct round-trips lose precision and every Go destination's write test suite fails.Route nested types through
UnmarshalOnewithUseNumberin each destination read path, and correct two float64-rounded literals in the transformer/basic test.Blocked on cloudquery/plugin-sdk#2553 — the SDK's own test helpers hit the same lossy path, so CI here stays red until that ships. The file/s3/gcs/azblob destinations additionally need cloudquery/filetypes#757.