feat: Implement Transform function in Plugin proto file.#23
Merged
marianogappa merged 1 commit intomainfrom Jul 17, 2024
Merged
feat: Implement Transform function in Plugin proto file.#23marianogappa merged 1 commit intomainfrom
marianogappa merged 1 commit intomainfrom
Conversation
marianogappa
commented
Jul 17, 2024
| bytes record = 1; | ||
| } | ||
| message Response { | ||
| // marshalled arrow.Record |
Contributor
Author
There was a problem hiding this comment.
As mentioned in the meeting, this is compatible with sending something other than arrow.Record in the future
erezrokah
approved these changes
Jul 17, 2024
Member
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
Looks good, we might want to pass in tables/skip tables/other options at some point but we can do this in a backwards compatible way
erezrokah
changed the title
erezrokah
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.