Skip to content

feat: Implement Transform function in Plugin proto file. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marianogappa merged 1 commit into from
Jul 17, 2024
Merged

feat: Implement Transform function in Plugin proto file. #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions plugin/v3/plugin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ service Plugin {
rpc Read(Read.Request) returns (stream Read.Response);
// Write resources. Write is the mirror of Sync, expecting a stream of messages as input.
rpc Write(stream Write.Request) returns (Write.Response);
// Transform resources.
rpc Transform(stream Transform.Request) returns (stream Transform.Response);
// Send signal to flush and close open connections
rpc Close(Close.Request) returns (Close.Response);
// Validate and test the connections used by the plugin
Expand Down Expand Up @@ -190,6 +192,17 @@ message Write {
message Response {}
}

message Transform {
message Request {
// marshalled arrow.Record
bytes record = 1;
}
message Response {
// marshalled arrow.Record
Copy link
Copy Markdown
Contributor Author

@marianogappa marianogappa Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the meeting, this is compatible with sending something other than arrow.Record in the future

bytes record = 1;
}
}

message Close {
message Request {}
message Response {}
Expand Down