fix: Print correct number of table resources #143
Conversation
schema/table.go
Outdated
| } | ||
| } | ||
|
|
||
| totalResources++ |
There was a problem hiding this comment.
Incrementing when we send the result to the channel seems more clear to me than counting all the objects before the loop
There was a problem hiding this comment.
Maybe worth adding a separate log message for relations if we don't have one
|
Counter-point: I think we should count relations, or at least report them; we're doing non-trivial work and API calls to fetch them. The ideal would be to report on relational table counts separately--not sure how easy that would be to do in practice |
💯 Agree we should count them separately. Let me see if I can add it to this PR |
erezrokah
force-pushed
the
fix/dont_count_relations
branch
from
b078932 to
97e7c73
Compare
erezrokah
changed the title
|
@hermanschaaf I changed the PR to print total for both relations and top level tables, and keep the total count a sum of all tables |
🤖 I have created a release *beep* *boop* --- ## [0.7.8](v0.7.7...v0.7.8) (2022-09-20) ### Bug Fixes * Print correct number of table resources ([#143](#143)) ([bcbd2a2](bcbd2a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
3 participants
Summary
Fixes #114
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)